Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misusing SameSite Attribute For Cookies #198

Open
charJe opened this issue Sep 5, 2021 · 2 comments
Open

Misusing SameSite Attribute For Cookies #198

charJe opened this issue Sep 5, 2021 · 2 comments

Comments

@charJe
Copy link

charJe commented Sep 5, 2021

Cookie “test-cookie” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

set-cookie doesn't have a same-site option.

@MichaelAnckaert
Copy link

@charJe The current version on the master branch has this option. It seems the latest release (1.3.0 at time of writing - also the one in QuickLisp) lacks the option.

You can clone the git repository in your quicklisp/local-projects directory to use the up to date version.

@jkcunningham
Copy link

Cloning the git repo in quicklisp/local-projects indeed provides the needed SameSite attribute in the cookie object. However, there isn't any easy way to set it when a session starts. I've temporarily solved this problem by adding (defparameter default-cookie-same-site nil) above that function in session.lilsp and setting :same-site to default-cookie-same-site in the start-session set-cookie call. Doing this makes it transparent to other users and allows me to change that global parameter after I load hunchentoot.

But I'm going to have to do that everytime I update hunchentoot. It would be nice to get some control over this built in in the project itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants