Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish different errors when relating an update channel to target groups #529

Open
davidebriani opened this issue May 27, 2024 · 1 comment · May be fixed by #771
Open

Distinguish different errors when relating an update channel to target groups #529

davidebriani opened this issue May 27, 2024 · 1 comment · May be fixed by #771
Assignees
@lusergit
Labels
ash-porting Issues used to track open issues regarding the Ash porting process enhancement New feature or request

Comments

@davidebriani
Copy link
Collaborator

davidebriani commented May 27, 2024 •
edited
Loading

Currently, a single generic error is returned when an update channel cannot be correctly related to a list of target groups: for example if some target groups don't exist or are already related to an update channel.

A possible approach could be to use Ash.Expr as suggested here: #521 (comment)
@davidebriani davidebriani added enhancement New feature or request ash-porting Issues used to track open issues regarding the Ash porting process labels May 27, 2024
@lusergit lusergit self-assigned this Dec 10, 2024
@lusergit
Copy link
Collaborator

I was looking at the code from #521 (comment), in the discussion you mentioned that the code was not working, but by plugging it in and running some tests it actually worked, what was the issue here?

It can be cleaned a bit but I think it can actually solve the issue

lusergit added a commit to lusergit/edgehog that referenced this issue Dec 10, 2024
@lusergit
chore(update_channel): better errors
cf2afac 
When creating and updating an update channel, target group ids are
validated to be available, meaning:
- they are present in the DB
- they are not related to any other update channel

closes edgehog-device-manager#529

Signed-off-by: Luca Zaninotto <[email protected]>
lusergit added a commit to lusergit/edgehog that referenced this issue Dec 10, 2024
@lusergit
chore(update_channel): better errors
c249a35 
When creating and updating an update channel, target group ids are
validated to be available, meaning:
- they are present in the DB
- they are not related to any other update channel

closes edgehog-device-manager#529

Signed-off-by: Luca Zaninotto <[email protected]>
@lusergit lusergit linked a pull request Dec 10, 2024 that will close this issue
Open
lusergit added a commit to lusergit/edgehog that referenced this issue Dec 10, 2024
@lusergit
chore(update_channel): better errors
158b288 
When creating and updating an update channel, target group ids are
validated to be available, meaning:
- they are present in the DB
- they are not related to any other update channel

closes edgehog-device-manager#529

Signed-off-by: Luca Zaninotto <[email protected]>
lusergit added a commit to lusergit/edgehog that referenced this issue Dec 10, 2024
@lusergit
chore(update_channel): better errors
7e9c7e0 
When creating and updating an update channel, target group ids are
validated to be available, meaning:
- they are present in the DB
- they are not related to any other update channel

closes edgehog-device-manager#529

Signed-off-by: Luca Zaninotto <[email protected]>
lusergit added a commit to lusergit/edgehog that referenced this issue Dec 12, 2024
@lusergit
chore(update_channel): better errors
aa65a2b 
When creating and updating an update channel, target group ids are
validated to be available, meaning:
- they are present in the DB
- they are not related to any other update channel

closes edgehog-device-manager#529

Signed-off-by: Luca Zaninotto <[email protected]>
lusergit added a commit to lusergit/edgehog that referenced this issue Dec 12, 2024
@lusergit
chore(update_channel): better errors
0173107 
When creating and updating an update channel, target group ids are
validated to be available, meaning:
- they are present in the DB
- they are not related to any other update channel

closes edgehog-device-manager#529

Signed-off-by: Luca Zaninotto <[email protected]>
lusergit added a commit to lusergit/edgehog that referenced this issue Dec 12, 2024
@lusergit
chore(update_channel): better errors
332fea1 
When creating and updating an update channel, target group ids are
validated to be available, meaning:
- they are present in the DB
- they are not related to any other update channel

closes edgehog-device-manager#529

Signed-off-by: Luca Zaninotto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lusergit lusergit

Labels
ash-porting Issues used to track open issues regarding the Ash porting process enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(update_channel): better errors lusergit/edgehog
2 participants
@lusergit @davidebriani