Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ethers package #262

Open
annybs opened this issue Jun 16, 2023 · 0 comments
Open

Remove ethers package #262

annybs opened this issue Jun 16, 2023 · 0 comments

Comments

@annybs
Copy link
Member

annybs commented Jun 16, 2023

While working on optimising the JS payload, I found that the ethers package accounts for 186.94kB of production output, or about 15% of total.

We only use a single function from it, in one place only, to format an ETH amount.

This dependency is drastically oversized for our requirements! We should reimplement the method by copy-paste and remove the package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annybs @adamkdean