Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConverterId in JSF files not transformed #695

Open
udengaardandersent-ELS opened this issue Nov 15, 2024 · 1 comment
Open

ConverterId in JSF files not transformed #695

udengaardandersent-ELS opened this issue Nov 15, 2024 · 1 comment

Comments

@udengaardandersent-ELS
Copy link

Problem Description

Package names in JSP/JSF files may not be transformed.

Steps to reproduce

Example 1: sample.xhtml

Have text fields hooked together with converter strategy

<p:field label="between"
	layout="inline" labelPosition="between year">
	<p:textfield value="#{cc.attrs.filter.fromYear}">
	<f:converter converterId="javax.faces.Integer"/>
	</p:textfield>
</p:field>
<p:field label="and" layout="inline" labelPosition="and">
	<p:textfield value="#{cc.attrs.filter.toYear}">
	<f:converter converterId="javax.faces.Integer"/>
	</p:textfield>
</p:field>

I tested converting a large javaEE webapp and discovered some errors on specific pages, and tracked the error related to not locating "javax.faces.Integer".

I did manually adjust this specific page with new identifier "jakarta.faces.Integer".
Next recompiling war to javaEE8, then transform to EE10 and running it on tomcat10+ and the pages work as expected.

Is this outside the scope of the transformer, does it only apply for java classes?

@bjhargrave
Copy link
Member

The transformer can also transform text in non-java files. You may need to specify the necessary configuration to get your use case addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants