Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscribeMany and UnsubscribeMany responses contain pointers instead of QoS #216

Open
Arnavion opened this issue Dec 6, 2023 · 0 comments
Open

SubscribeMany and UnsubscribeMany responses contain pointers instead of QoS #216

Arnavion opened this issue Dec 6, 2023 · 0 comments
Labels
bug fix added A fix was added to an unreleased branch
Milestone
v0.13

Comments

@Arnavion
Copy link

Arnavion commented Dec 6, 2023

The code is casting *mut MQTTReasonCodes -> i32 instead of the intended MQTTReasonCodes -> i32

https://github.com/eclipse/paho.mqtt.rust/blob/cf953b937eaa66c436e746dcfde98d2bf61b36ac/src/server_response.rs#L208

-qosv.push(rsp.alt.sub.reasonCodes.add(i) as i32);
+qosv.push(*rsp.alt.sub.reasonCodes.add(i) as i32);

https://github.com/eclipse/paho.mqtt.rust/blob/cf953b937eaa66c436e746dcfde98d2bf61b36ac/src/server_response.rs#L227

-qosv.push(rsp.alt.unsub.reasonCodes.add(i) as i32);
+qosv.push(*rsp.alt.unsub.reasonCodes.add(i) as i32);
fpagliughi added a commit that referenced this issue May 25, 2024
@fpagliughi
#216 Deref QoS pointers for SubscribeMany and UnsubscribeMany in serv…
6a992ed 
…er response
@fpagliughi fpagliughi added bug fix added A fix was added to an unreleased branch labels May 25, 2024
@fpagliughi fpagliughi added this to the v0.13 milestone May 25, 2024
fpagliughi added a commit that referenced this issue May 25, 2024
@fpagliughi
#216 Deref QoS pointers for SubscribeMany and UnsubscribeMany in serv…
25059f5 
…er response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fix added A fix was added to an unreleased branch
Projects
None yet
Milestone
v0.13
Development

No branches or pull requests
2 participants
@Arnavion @fpagliughi