Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need method in invoke_method? #117

Closed
evshary opened this issue May 29, 2024 · 3 comments
Closed

Do we still need method in invoke_method? #117

evshary opened this issue May 29, 2024 · 3 comments
Labels
question Further information is requested

Comments

@evshary
Copy link
Contributor

evshary commented May 29, 2024

Now the prototype of invoke_method is async fn invoke_method(&self, method: UUri, request: UMessage) -> RpcClientResult;

async fn invoke_method(&self, method: UUri, request: UMessage) -> RpcClientResult;

Since UMessage contains the information of source and sink, I'm wondering whether we still need method: UUri here.
I found that all I need is UMessage while implementing up-client-zenoh-rust.

@sophokles73
Copy link
Contributor

Yes, I agree that the method parameter is no longer needed/useful. I am currently working on a PR to add the Level 2 API to up-rust. As part of that, I will adapt the function's signature accordingly.

@sophokles73
Copy link
Contributor

this will be changed as part of #122

@sophokles73 sophokles73 added the question Further information is requested label Jun 17, 2024
@sophokles73
Copy link
Contributor

As it turns out, the RpcClient's invoke_method function now accepts the method, call options and payload as separate parameters again. Closed via 7148f78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants