Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All interfaces taking std::function objects should wrap them in a callback connection #195

Open
gregmedd opened this issue Jun 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gregmedd
Copy link
Contributor

Following on #194, some L2 communications modules take callback functions and wrap them in another callback before registering them with the transport. These should always be wrapped in a connection that is either a) stored in the L2 module instance (when the callback is provided at construction time) or b) returned to the caller (such as in the RpcClient case where new callbacks are provided every time).

@gregmedd gregmedd added the bug Something isn't working label Jun 27, 2024
@gregmedd gregmedd added this to the alpha.2 milestone Jun 27, 2024
@gregmedd gregmedd self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant