Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all warnings in build #189

Closed
MarkStokes71 opened this issue Jun 26, 2024 · 2 comments · Fixed by #211
Closed

Enable all warnings in build #189

MarkStokes71 opened this issue Jun 26, 2024 · 2 comments · Fixed by #211
Assignees
@ruchirchauhan
Labels
enhancement New feature or request
Milestone
alpha.3

Comments

@MarkStokes71
Copy link
Contributor

Add -Wall to the build (both the main project and the UT's.
@gregmedd gregmedd added the enhancement New feature or request label Jun 27, 2024
@gregmedd gregmedd added this to the alpha.3 milestone Jun 27, 2024
@gregmedd
Copy link
Contributor

Items this task should address:

  1. Add the -Wall flag in the main CMakeLists.txt file
  2. Verify it is also applied to unit tests (this should be propagated from the top-level build file)
  3. Address any warnings found.

@ruchirchauhan
Copy link
Contributor

I can take this

@gregmedd gregmedd linked a pull request Jul 11, 2024 that will close this issue
Enable build warnings and fix the warnings #211
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruchirchauhan ruchirchauhan

Labels
enhancement New feature or request
Projects
API Rewrite: up-cpp for 1.5.8
Status: Done
Milestone
alpha.3
Development

Successfully merging a pull request may close this issue.

Enable build warnings and fix the warnings ruchirchauhan/up-cpp
3 participants
@gregmedd @ruchirchauhan @MarkStokes71