-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write extra RpcClientTest for up-cpp #174
Comments
I will work on this. |
I have a first working full circuit test of this. |
@debruce - Has this been put out for review yet? |
The PR is here: #275 Warning: member variable 'rpc_service_uuri_' has public visibility Still looking at fixes. Strangely, seems like the CI no longer makes line numbers visible for the locations of the errors. |
I fixed the various clang-tidy problems with the additions of '// NOLINT' to all of the lines except for rpc_service_uuri and ident, which had a more proper fix. |
This has been rebased to the top of main this morning. I think its ready for review. |
The “extra” tests provide for more integrated testing than lower-level “coverage” unit tests. They check the interoperation between components. However, they do not count towards code coverage as their assertions are made at a higher level where detailed behaviors may be missed.
This test will exercise the interoperability between RpcClient and RpcServer. Are messages produced by one compatible with the other? Does the servers’s listener registration match up with the URIs in a request (i.e. does everything end up in the expected spots)? And in the reverse direction for responses? Do responses find their way to the right place? Does everything validate successfully after being passed through all stages?
The text was updated successfully, but these errors were encountered: