Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write extra RpcClientTest for up-cpp #174

Closed
gregmedd opened this issue Jun 22, 2024 · 6 comments · Fixed by #275 or #290
Closed

Write extra RpcClientTest for up-cpp #174

gregmedd opened this issue Jun 22, 2024 · 6 comments · Fixed by #275 or #290
Assignees
Milestone

Comments

@gregmedd
Copy link
Contributor

The “extra” tests provide for more integrated testing than lower-level “coverage” unit tests. They check the interoperation between components. However, they do not count towards code coverage as their assertions are made at a higher level where detailed behaviors may be missed.

This test will exercise the interoperability between RpcClient and RpcServer. Are messages produced by one compatible with the other? Does the servers’s listener registration match up with the URIs in a request (i.e. does everything end up in the expected spots)? And in the reverse direction for responses? Do responses find their way to the right place? Does everything validate successfully after being passed through all stages?

@gregmedd gregmedd added this to the alpha.3 milestone Jul 12, 2024
@debruce
Copy link
Contributor

debruce commented Jul 17, 2024

I will work on this.

@debruce
Copy link
Contributor

debruce commented Jul 30, 2024

I have a first working full circuit test of this.

@gregmedd gregmedd modified the milestones: alpha.3, alpha.4 Jul 30, 2024
@gregmedd
Copy link
Contributor Author

gregmedd commented Aug 8, 2024

@debruce - Has this been put out for review yet?

@gregmedd gregmedd linked a pull request Aug 9, 2024 that will close this issue
@debruce
Copy link
Contributor

debruce commented Aug 12, 2024

The PR is here: #275
I have the following clang-tidy problems:

Warning: member variable 'rpc_service_uuri_' has public visibility
Warning: member variable 'ident_' has public visibility
Warning: all parameters should be named in a function
Warning: do not use namespace using-directives; use using-declarations instead
Warning: variable 'client_capture' is not initialized
Warning: variable 'server_capture' is not initialized
Warning: variable 'client_handle' is not initialized

Still looking at fixes. Strangely, seems like the CI no longer makes line numbers visible for the locations of the errors.

@debruce
Copy link
Contributor

debruce commented Aug 12, 2024

I fixed the various clang-tidy problems with the additions of '// NOLINT' to all of the lines except for rpc_service_uuri and ident, which had a more proper fix.

@debruce
Copy link
Contributor

debruce commented Aug 14, 2024

This has been rebased to the top of main this morning. I think its ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants