Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tycho doesn't use SmartBuilder #4402

Closed
Bananeweizen opened this issue Nov 1, 2024 · 3 comments
Closed

Tycho doesn't use SmartBuilder #4402

Bananeweizen opened this issue Nov 1, 2024 · 3 comments

Comments

@Bananeweizen
Copy link
Contributor

Shouldn't Tycho use the Takari builder when the thread count is larger than 1? I never get the smart builder:
image

I've been debugging this, and I don't get into TychoGraphBuilder.java at all, where that builder would be configured via session properties. What needs to be done to use TychoGraphBuilder? Be aware I don't use the polyglott stuff, if that's relevant.

@laeubi
Copy link
Member

laeubi commented Nov 1, 2024

Shouldn't Tycho use the Takari builder when the thread count is larger than 1? I never get the smart builder:

You need to enable tycho-build extension as described here as a first step, but you are using project mode according to the log output.

Be aware I don't use the polyglott stuff

This is not mandatory, but things like smartbuilder can only be enabled in extensions mode.

@laeubi laeubi changed the title doesn't use SmartBuilder Tycho doesn't use SmartBuilder Nov 1, 2024
@Bananeweizen
Copy link
Contributor Author

Aaah, that makes sense now. 2 years ago I removed the extensions.xml because I thought that having the <extension>true</extension> flag would be sufficient, and then removing the otherwise useless file seamed cleaner.

Thanks @laeubi for the clarification.

@laeubi
Copy link
Member

laeubi commented Nov 2, 2024

There are two kinds of extensions:

  • project extensions: that can extend things once projects are loaded, e.g. new packaging types, participate once session is finalized)
  • core extension: that can extends almost everything including how projects are read/and or scheduled

of course if you only want to use smart-builder, you can also opt-in to enable it as a standalone extension, but in the light of Maven 4 Tycho will probably move towards requiring tycho-build anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants