Getting tycho-source-plugin:generate-pde-source-header working with packaging type jar

[phermsdorf]

Hi,

I'm trying to generate eclipse source bundles for maven modules that generate their MANIFEST.MF with maven-bundle-plugin in a mixed reactor setup.

A problem seems to be that the packaging type for this modules is jar and not bundle (where everything is working as expected).

I have re-created our setup based on the ITS test here:
https://github.com/eclipse-tycho/tycho/tree/main/tycho-its/projects/mixed.reactor

In the felix.bundle module change the packaging to jar and add this executions block to the maven-bundle-plugin configuration:

<executions>
	<execution>
		<id>create-ide-manifest</id>
		<goals>
			<goal>manifest</goal>
		</goals>
	</execution>
	<execution>
		<id>default-bundle</id>
		<phase>package</phase>
		<goals>
			<goal>bundle</goal>
		</goals>
	</execution>
</executions>

That seems to be neccessary for the MANIFEST generation and bundling to the jar file.

When running the build i see:

[INFO] --- tycho-source:4.0.13:generate-pde-source-header (generate-pde-source-header) @ felix.bundle ---
[WARNING] Bundle-Name header not found in /META-INF/MANIFEST.MF, fallback to Bundle-SymbolicName for source bundle
[WARNING] Bundle-Vendor header not found in /META-INF/MANIFEST.MF, fallback to 'unknown' for source bundle

and then it fails with:
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-source-plugin:4.0.13:generate-pde-source-header (generate-pde-source-header) on project felix.bundle: Update of manifest failed!: Cannot invoke "String.length()" because "str" is null -> [Help 1]

The root cause seems to be that the maven.bundle-plugin bundle goal was not executed before the tycho-source.plugin. I tried binding the bundle goal to the prepare-package phase but then the maven-jar plugin fails with You have to use a classifier to attach supplemental artifacts to the project instead of replacing them.

Is there an advice to get that setup running?
I want to keep the packaging type jar since the modules are run in an non-osgi environment as well (on server side)...

Thanks for any hints on this.
Bye Peter

[phermsdorf]

moving the generate-pde-source-header goal of tycho-source-plugin to the pre-integration-test phase seems to work, but still looks a bit odd ...

(this causes the maven-bundle-plugin to run in the package phase and afterwards the source headers can be created in the pre-integration-test phase)

[laeubi]

@phermsdorf if I rember correctly @HannesWell enhanced that mojo to be used in m2e for a similar purpose:

https://github.com/eclipse-m2e/m2e-core/blob/b4ebdd8561c8c49720258d2be0573f692f3c22f4/org.eclipse.m2e.maven.runtime/pom.xml#L413-L427

and it seem to work there in package phase, it also seem to be not having issues with bundle packaging.

As we even have integration tests for this in PDESourceHeaderGenerationTest you maybe want to check what is different here. If anything needs to be enhanced please don't hesitate to propose a PR!