What is the way to automatically generate Require-Bundle based on pom.xml dependencies?

[vlsi]

Here's my use case: vlsi/mat-calcite-plugin#31

I need org.apache.calcite:calcite-core:1.36.0 dependency which is nowhere near being a bundle, and I need its transitive dependencies otherwise it fails at the runtime.

I want to build a plugin for Eclipse Memory Analyzer, so I think I need Require-Bundle: ... to list the dependencies. I hope to be wrong here, however, I was not able to build the project without Require-Bundle.

Previously, I used a workaround of creating MatCalciteDependencies Maven project which was just shading org.apache.calcite:calcite-core and all its transitive dependencies into an uberjar, and then I used that uberjar as a single bundle in Require-Bundle.
It worked to a degree, however, it requires two-stage build: first I need to build the uberjar, and only then I can use it. The second drawback is I can't easily debug since source jars are not present. I can probably create "source uberjar" for debugging purposes.

This time I tried upgrading tycho 1.3.0->4.0.3 :), and I thought: "Well, what if I could drop MatCalciteDependencies, and make tycho figure out Require-Bundle based on pom.xml?"

Unfortunately, it did not work.
I still have to list bundle names explicitly, and it is especially painful when some of the dependencies are bundles and some are not.
See https://github.com/vlsi/mat-calcite-plugin/pull/31/files#diff-4e1b7f2f0a49306a6a23a64865e569a6b8ebdaff661712980e4decf6ff724b59R8 for the list of bundle names I had do spell out manually.

Is there a way to use Maven dependencies without resorting to multi-stage shaded builds and without spelling out every dependency in Require-Bundle?

[laeubi]

Unfortunately, it did not work.

You should specify what did not work. Did the build fails? Can't you install in Eclipse? Anything else?

Is there a way to use Maven dependencies without resorting to multi-stage shaded builds and without spelling out every dependency in Require-Bundle?

Yes you can use a "maven target location" see:

• Update MatCalciteTargetPlatform.target vlsi/mat-calcite-plugin#32

by the way Eclipse Photon is heavily outdated, you probably want to upgrade that as well...

Beside that, don't user require bundle, use import package!

[vlsi]

https://github.com/apache/calcite/blob/calcite-1.36.0/core/src/main/java/org/apache/calcite/util/BuiltInMethod.java#L403

enum BuiltInMethod uses org.apache.calcite.runtime.JsonFunctions.class in its initialization, and JsonFunctions uses com.fasterxml.jackson.core.util in its private final static: https://github.com/apache/calcite/blob/calcite-1.36.0/core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java#L81-L83

It causes NCDFE in runtime even though com.fasterxml.jackson.core.jackson-core is a bundle, and the dependency on com/fasterxml/jackson/core/util/DefaultPrettyPrinter$Indenter does not use Class.forName(...).

Can I somehow adjust bnd instuctions in such a way so it does not use optional dependencies?

Caused by: java.lang.NoClassDefFoundError: Could not initialize class org.apache.calcite.adapter.enumerable.RexImpTable
	at org.apache.calcite.schema.impl.ScalarFunctionImpl.createImplementor(ScalarFunctionImpl.java:167)
	at org.apache.calcite.schema.impl.ScalarFunctionImpl.create(ScalarFunctionImpl.java:139)
	at org.apache.calcite.schema.impl.ScalarFunctionImpl.functions(ScalarFunctionImpl.java:99)
	at com.github.vlsi.mat.calcite.neo.PackageSchema.resolveSchema(PackageSchema.java:103)
	at com.github.vlsi.mat.calcite.CalciteDataSource$1.load(CalciteDataSource.java:30)
	at com.github.vlsi.mat.calcite.CalciteDataSource$1.load(CalciteDataSource.java:26)
	at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3576)
	at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2318)
	at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2191)
	at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2081)
	... 64 more
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/util/DefaultPrettyPrinter$Indenter [in thread "main"]
	at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
	at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3402)
	at java.base/java.lang.Class.getMethodsRecursive(Class.java:3543)
	at java.base/java.lang.Class.getMethod0(Class.java:3529)
	at java.base/java.lang.Class.getMethod(Class.java:2225)
	at org.apache.calcite.linq4j.tree.Types.lookupMethod(Types.java:309)
	at org.apache.calcite.util.BuiltInMethod.<init>(BuiltInMethod.java:882)
	at org.apache.calcite.util.BuiltInMethod.<clinit>(BuiltInMethod.java:403)
	at org.apache.calcite.adapter.enumerable.RexImpTable$Builder.populate(RexImpTable.java:522)
	at org.apache.calcite.adapter.enumerable.RexImpTable.<clinit>(RexImpTable.java:475)
	at org.apache.calcite.schema.impl.ScalarFunctionImpl.createImplementor(ScalarFunctionImpl.java:167)
	at org.apache.calcite.schema.impl.ScalarFunctionImpl.create(ScalarFunctionImpl.java:139)
	at org.apache.calcite.schema.impl.ScalarFunctionImpl.functions(ScalarFunctionImpl.java:99)

[laeubi]

It causes NCDFE in runtime even though

"It" is "org.apache.calcite.linq4j" what does not seem to have proper imports.

Can I somehow adjust bnd instuctions in such a way so it does not use optional dependencies?

Just open the target and go to "Edit instructions" on the maven location.

[vlsi]

"It" is "org.apache.calcite.linq4j" what does not seem to have proper imports.

You are right, org.apache.calcite.linq4j is not a bundle, however, it looks like I have to specify all the dependencies of all non-bundles :-/

[laeubi]

it looks like I have to specify all the dependencies of all non-bundles :-/

You don't have to ... see above, it is enough to make then somehow available, it could be a feature, an import (of one package), a product, additional test-run dependencies ... or you can modify the instructions, but that is quite hard work if it comes to more than a few non-osgi ones.

[vlsi]

Ok, thanks for the help. I have 14 non-osgi ones, and getting them to add/fix the metadata and release would be a challenge.

[laeubi]

Please read what I wrote above, you can adjust it in your target file, neverless on the long run it is more practical to have proper osgi data in the first place...

[vlsi]

an import (of one package)

That seems to work indeed.

I've finally got a workable build with Import-Package entries: vlsi/mat-calcite-plugin#33

Many thanks for the quick feedback.

[laeubi]

By the way you might want to ask these project that currently do not have osgi-metadata to add those to their bundles