Tycho 3.0.0 crash when connecting to secured P2 repository #1504

Zegveld · 2022-10-10T15:49:35Z

Zegveld
Oct 10, 2022

I'm upgrading from tycho 2.6.0 where everything works fine to tycho 3.0.0 and there I run into the following crash:

[INFO] --- target-platform-validation-plugin:3.0.0:validate-target-platform (default) @ targetplatform ---
[INFO] Validating *****\eclipse-targetplatform\targetplatform.target...
[INFO] ### Using TychoRepositoryTransport for remote P2 access ###
[INFO]     Cache location:         *****\targetplatformrepo\.cache\tycho
[INFO]     Transport mode:         online
[INFO]     Update mode:            cache first
[INFO]     Minimum cache duration: 60 minutes
[INFO]       (you can configure this with -Dtycho.p2.transport.min-cache-minutes=<desired minimum cache duration>)
[INFO] Resolving target definition file:/*****/eclipse-targetplatform/targetplatform.target for environments=[win32/win32/x86_64], include source mode=honor, execution environment=StandardEEResolutionHints [executionEnvironment=OSGi profile 'JavaSE-17' { source level: 17, target level: 17}], remote p2 repository options=org.eclipse.tycho.p2.remote.RemoteAgent@1572b7e4...
[INFO] Failed, see Error log below
[ERROR] Validation found errors in 1 .target files:
Could not resolve content of targetplatform.target
java.lang.RuntimeException: org.eclipse.equinox.security.storage.StorageException: Unable to locate secure storage module (org.eclipse.equinox.security.windowspasswordprovider64bit).
        at org.eclipse.tycho.p2maven.helper.P2PasswordUtil.setCredentials(P2PasswordUtil.java:61)
        at org.eclipse.tycho.p2maven.repository.RemoteRepositoryLoadingHelper.setPasswordForLoading(RemoteRepositoryLoadingHelper.java:132)
        at org.eclipse.tycho.p2maven.repository.RemoteRepositoryLoadingHelper.getEffectiveLocationAndPrepareLoad(RemoteRepositoryLoadingHelper.java:90)
        at org.eclipse.tycho.p2.remote.RemoteMetadataRepositoryManager.translateAndPrepareLoad(RemoteMetadataRepositoryManager.java:50)
        at org.eclipse.tycho.p2.remote.RemoteMetadataRepositoryManager.loadRepository(RemoteMetadataRepositoryManager.java:62)
        at org.eclipse.tycho.p2.remote.RemoteMetadataRepositoryManager.loadRepository(RemoteMetadataRepositoryManager.java:56)
        at org.eclipse.tycho.p2.resolver.URITargetDefinitionContent.preload(URITargetDefinitionContent.java:76)
        at org.eclipse.tycho.p2.resolver.URITargetDefinitionContent.query(URITargetDefinitionContent.java:53)
        at org.eclipse.equinox.p2.query.CompoundQueryable.getIteratorFromQueryable(CompoundQueryable.java:178)
        at org.eclipse.equinox.p2.query.CompoundQueryable.everything(CompoundQueryable.java:124)
        at org.eclipse.equinox.internal.p2.metadata.expression.RepeatableIterator$IndexProviderIterator.<init>(RepeatableIterator.java:142)
        at org.eclipse.equinox.internal.p2.metadata.expression.RepeatableIterator.create(RepeatableIterator.java:60)
        at org.eclipse.equinox.internal.p2.metadata.expression.Everything.<init>(Everything.java:39)
        at org.eclipse.equinox.internal.p2.metadata.expression.ContextExpression.createContext(ContextExpression.java:48)
        at org.eclipse.equinox.p2.query.ExpressionQuery.perform(ExpressionQuery.java:51)
        at org.eclipse.equinox.internal.p2.metadata.index.IndexProvider.query(IndexProvider.java:26)
        at org.eclipse.equinox.internal.p2.metadata.index.IndexProvider.query(IndexProvider.java:36)
        at org.eclipse.tycho.p2.resolver.InstallableUnitResolver.findUnit(InstallableUnitResolver.java:293)
        at org.eclipse.tycho.p2.resolver.InstallableUnitResolver.findUnits(InstallableUnitResolver.java:273)
        at org.eclipse.tycho.p2.resolver.InstallableUnitResolver.getRootIUs(InstallableUnitResolver.java:266)
        at org.eclipse.tycho.p2.resolver.InstallableUnitResolver.addLocation(InstallableUnitResolver.java:100)
        at org.eclipse.tycho.p2.target.TargetDefinitionResolver.resolveContentWithExceptions(TargetDefinitionResolver.java:153)
        at org.eclipse.tycho.p2.target.TargetDefinitionResolver.resolveContent(TargetDefinitionResolver.java:110)
        at org.eclipse.tycho.p2.target.TargetDefinitionResolverService.resolveFromArguments(TargetDefinitionResolverService.java:86)
        at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
        at org.eclipse.tycho.p2.target.TargetDefinitionResolverService.getTargetDefinitionContent(TargetDefinitionResolverService.java:59)
        at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.resolveTargetDefinitions(TargetPlatformFactoryImpl.java:212)
        at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.createTargetPlatform(TargetPlatformFactoryImpl.java:164)
        at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.createTargetPlatform(TargetPlatformFactoryImpl.java:137)
        at org.eclipse.tycho.p2.resolver.P2ResolverImpl.resolveMetadata(P2ResolverImpl.java:174)
        at org.eclipse.tycho.extras.tpvalidator.TPValidationMojo.validateTarget(TPValidationMojo.java:224)
        at org.eclipse.tycho.extras.tpvalidator.TPValidationMojo.execute(TPValidationMojo.java:153)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:289)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:193)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
Caused by: org.eclipse.equinox.security.storage.StorageException: Unable to locate secure storage module (org.eclipse.equinox.security.windowspasswordprovider64bit).
        at org.eclipse.equinox.internal.security.storage.PasswordProviderSelector.findStorageModule(PasswordProviderSelector.java:215)
        at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getModulePassword(SecurePreferencesRoot.java:227)
        at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getPassword(SecurePreferencesRoot.java:220)
        at org.eclipse.equinox.internal.security.storage.SecurePreferences.get(SecurePreferences.java:267)
        at org.eclipse.equinox.internal.security.storage.SecurePreferencesWrapper.get(SecurePreferencesWrapper.java:123)
        at org.eclipse.tycho.p2maven.helper.P2PasswordUtil.setCredentials(P2PasswordUtil.java:54)
        ... 53 more

The P2 is hosted at our company nexus with user and password security, which is correctly supplied through the maven settings file since it works in 2.6.0.

Our ci-builds succeeds on this point. So I'm currently wondering what might be wrong with my system that it gives this error.

laeubi · 2022-10-10T15:54:16Z

laeubi
Oct 10, 2022
Maintainer

This is just an error print-out and as you said the build is not affected by this. I assume equinox tries to do something specific on windows but is unable to do so as tycho do not ship with the required fragment.

As we can't really build a "windows-tycho" its hard to solve though, you should provide an integration-test to demonstrate the issue, so we probably can try to investigate possible mitigations.

7 replies

Zegveld Oct 10, 2022
Author

windows in this case, that makes it even weirder.
and a clean repo did not work.

laeubi Oct 10, 2022
Maintainer

I just noticed you are using validate-target-platform mojo and that might be not really maintained/used much ...
Also org.eclipse.equinox.security.windowspasswordprovider64bit is nothing from Tycho but from equinox, so I have no clue how it dripp into your system at all...

Zegveld Oct 12, 2022
Author

tycho does make a request for it at org.eclipse.tycho.p2maven.helper.P2PasswordUtil.setCredentials(P2PasswordUtil.java:61).
This also happens when I try to build locally with a build that uses the target platform.

Could this perhaps be caused by the move of P2PasswordUtil from the org.eclipse.tycho.p2.resolver.impl OSGI module to the p2-maven-plugin maven module?
Perhaps there is something listed inside the Manifest.MF at the OSGI-module which was responsible for it correctly working back then.....

Also enforcing that the dependency is added through the <dependencies> tag doesn't fix this issue.

Zegveld Oct 12, 2022
Author

For creating an integration-test (reproduction), is there a p2 repository available with user/password protection that I could use?

laeubi Oct 12, 2022
Maintainer

You can take a look at https://github.com/eclipse-tycho/tycho/blob/master/tycho-its/src/test/java/org/eclipse/tycho/test/target/PasswordProtectedP2RepositoryTest.java

CasperNLD · 2024-01-23T11:11:27Z

CasperNLD
Jan 23, 2024

This problem is also present in version 3.0.5. FYI
In regard to the former conversation, I have a question. I have the test, but we do not have a P2-repo which we can use to make a log.
Is there a test-repo I can use?

1 reply

laeubi Jan 23, 2024
Maintainer

You can look how these tests handle their repositories:
https://github.com/eclipse-tycho/tycho/tree/main/tycho-its

please keep in mind that Tycho 3.x is EOL and its unlikely receiving any updates / releases and the problem is already fixed for Tycho 4.x

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tycho 3.0.0 crash when connecting to secured P2 repository #1504

{{title}}

Replies: 2 comments 8 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Tycho 3.0.0 crash when connecting to secured P2 repository #1504

Zegveld Oct 10, 2022

Replies: 2 comments · 8 replies

laeubi Oct 10, 2022 Maintainer

Zegveld Oct 10, 2022 Author

laeubi Oct 10, 2022 Maintainer

Zegveld Oct 12, 2022 Author

Zegveld Oct 12, 2022 Author

laeubi Oct 12, 2022 Maintainer

CasperNLD Jan 23, 2024

laeubi Jan 23, 2024 Maintainer

Zegveld
Oct 10, 2022

Replies: 2 comments 8 replies

laeubi
Oct 10, 2022
Maintainer

Zegveld Oct 10, 2022
Author

laeubi Oct 10, 2022
Maintainer

Zegveld Oct 12, 2022
Author

Zegveld Oct 12, 2022
Author

laeubi Oct 12, 2022
Maintainer

CasperNLD
Jan 23, 2024

laeubi Jan 23, 2024
Maintainer