Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.eslintrc.js Usage #46

Open
egekorkan opened this issue Aug 2, 2024 · 5 comments · May be fixed by #49
Open

.eslintrc.js Usage #46

egekorkan opened this issue Aug 2, 2024 · 5 comments · May be fixed by #49

Comments

@egekorkan
Copy link
Member

egekorkan commented Aug 2, 2024

I checked and we do not have an .eslintrc.js. We have .eslintrc.json which serves another purpose. Shall we do it in a follow-up issue/PR because I think we will see many other changes also.

Originally posted by @danielpeintner in #34 (comment)

@egekorkan
Copy link
Member Author

@danielpeintner could you integrate that?

@danielpeintner
Copy link
Member

I quickly checked and I am no longer sure about the difference between the two files...

node-wot has .eslintrc.js while td-tools has .eslintrc.json
@egekorkan you created it initially ..

@danielpeintner danielpeintner linked a pull request Aug 7, 2024 that will close this issue
@JKRhb
Copy link
Member

JKRhb commented Aug 13, 2024

Hmm, I think .eslintrc.js is just a JS-based version of .eslintrc.json, so just a different format for the same configuration options.

@egekorkan
Copy link
Member Author

Reading up on this from here, js version is simply more feature rich due to being a program in the first place. I think we should simply take the js version everywhere where we have a common section. Each repo can then extend it as needed.

I have created the json version without thinking too much and would be happy to make this change. Any opinions?

@JKRhb
Copy link
Member

JKRhb commented Aug 14, 2024

Reading up on this from here, js version is simply more feature rich due to being a program in the first place. I think we should simply take the js version everywhere where we have a common section. Each repo can then extend it as needed.

I think these are very good reasons for making a switch to the JS variant :)

I have created the json version without thinking too much and would be happy to make this change.

That would be great!

It seems that using the JS variant could also enable us to create a reusable base config that we could refer to via package.json and then extend if needed. Maybe that is a bit overkill at this point, but if we have more packages in the future, that could be something to consider to have a consistent configuration across all Thingweb repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants