Breakpoint markers are not updated when debugging starts #14096
Comments
mvtec-richter
added a commit
to mvtecsoftware/theia
that referenced
this issue
Dec 17, 2024
Previously, when starting to debug, the breakpoints did not move to valid lines. The breakpoints were send to the debug adapter before configurationDone and some debug adapters (e. g. python) return updated positions directly. The updates were not visible in the editor, because the connection was not marked as initialized yet and events were ignored. The updates became only visible, when changing breakpoints later. This commit fixes this. Fixes eclipse-theia#14096 Signed-off-by: Florian Richter <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description:
Steps to Reproduce:
-> In python the breakpoint should disappear or be disabled (might be separate issue)
However the breakpoints stay at the invalid place
When adding/removing a breakpoint, the breakpoint is adapted
With another DAP server, the breakpoint might be moved to the next valid line.
The problem seems to be that in debug-session.tsx in the configure method, initialized is false, when this.updateBreakpoints is called.
updateBreakpoints will trigger an update of the UI, which calls getBreakpoints in debug-session-manager.ts. However, this returns the original breakpoints instead of the updated breakpoints from the DAP session, because the state of the session is still initializing and not running/stopped.
I could not reproduce this with the node/javascript extension, properly, because breakpoints are changed using a BreakpointEvent much later.
Additional Information
The text was updated successfully, but these errors were encountered: