Default Theme Configuration

[fipro78]

In the readme of @theia/cli is a section about how to configure a default theme:

https://github.com/eclipse-theia/theia/tree/master/dev-packages/cli#default-theme

IMHO this section is outdated. IIUC Theia replaced the custom theming with the VS Code Color Theme approach. Is my understanding correct? At least I do not see any Theia Theme package anymore and the VS Code Color Theme works AFAICS.

Instead of

"theia": {
    "frontend": {
      "config": {
        "defaultTheme": "light",
        "defaultIconTheme": "vs-seti"
      }
    }
  },

it should be configured via preferences

"theia": {
  "frontend": {
    "config": {
      "preferences": {
        "workbench.colorTheme": "light",
        "workbench.iconTheme": "vs-seti"
      }
    }
  }
}

[msujew]

Hey @fipro78,

Both definitely work. In the past, we had some extra handling for the defaultTheme item (like changing the color of the background when the app did its first startup), but I don't think anything of that is left anymore. But I just did a cursory glance, so don't take my word on it.

It might make sense to replace the defaultTheme and defaultIconTheme in favor of the preferences in the docs and then deprecate the properties in the config as well.