feat(rest): endpoint to get obligations depending upon obligation level #2611
+145
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudra-superrr
force-pushed
the
feat/projectPageObligations
branch
2 times, most recently
from
1085858
to
072a633
Compare
rudra-superrr
added
needs code review
needs general test
…tion level. Signed-off-by: Rudra Chopra <[email protected]>
rudra-superrr
force-pushed
the
feat/projectPageObligations
branch
from
072a633
to
dfa0948
Compare
|
Testing this PR |
|
Test was successful.
|
GMishx
removed
the
needs general test
GMishx
requested changes
Oct 17, 2024
| @RequestMapping(value = PROJECTS_URL + "/{id}/obligation", method = RequestMethod.GET) | ||
| public ResponseEntity<HalResource> getObligations(Pageable pageable, | ||
| @Parameter(description = "Project ID.") @PathVariable("id") String id, | ||
| @Parameter(description = "Obligation Level") |
There was a problem hiding this comment.
Please provide value set of supported values as OblLevel is a string.
| public ResponseEntity<HalResource> getObligations(Pageable pageable, | ||
| @Parameter(description = "Project ID.") @PathVariable("id") String id, | ||
| @Parameter(description = "Obligation Level") | ||
| @RequestParam(value = "obligationLevel", required = true) String OblLevel) |
There was a problem hiding this comment.
Suggested change
| @RequestParam(value = "obligationLevel", required = true) String OblLevel) | |
| @RequestParam(value = "obligationLevel", required = true) String oblLevel) |
| @@ -437,6 +439,28 @@ public ObligationList getObligationData(String linkedObligationId, User user) th | |||
| return sw360ProjectClient.getLinkedObligations(linkedObligationId, user); | |||
| } | |||
|
|
|||
| public Map<String, ObligationStatusInfo> setObligationsFromAdminSection(User user, Map<String, ObligationStatusInfo> obligationStatusMap, | |||
| Project project, String OblLevel) throws TException { | |||
There was a problem hiding this comment.
Suggested change
| Project project, String OblLevel) throws TException { | |
| Project project, String oblLevel) throws TException { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2610
Description: endpoint to get obligations depending upon obligation level (Possible values are: License, Project, Component, Organization).