docs: update to supported formats#124
Conversation
- move md to rst - regenerate diagrams in plantuml
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
|
@NicolasFussberger / @SimonKozik can you have a look |
|
|
||
| module/*/index | ||
| module/lifecycle_client_lib/lifecycle | ||
| module/lifecycle_client_lib/lifecyclemanager |
| } | ||
|
|
||
| App --|> mwApp : <<uses>> | ||
| App --> LifecycleManager : manages (run, terminate) |
There was a problem hiding this comment.
direction of the arrow is wrong
| class "Application Context" as AppCtx #0000FF { | ||
| } | ||
|
|
||
| App --|> mwApp : <<uses>> |
There was a problem hiding this comment.
original diagram says App --> mwApp : implements
and it is not an inheritance arrow but an implements arrow
|
|
||
| LifecycleManager --> ExecMgr : reports state (run, terminate) | ||
| LifecycleManager --> OS : handles application SIGTERM | ||
|
|
| LifecycleManager --> ExecMgr : reports state (run, terminate) | ||
| LifecycleManager --> OS : handles application SIGTERM | ||
|
|
||
| AppCtx --> ExecMgr : starts |
There was a problem hiding this comment.
The direction of the arrow is wrong
| mw::lifecycle | ||
| end note | ||
|
|
||
| @enduml |
There was a problem hiding this comment.
@PiotrKorkus would you be so kind to check the other diagrams first?
It seems the AI conversion introduced a bunch of errors.
You can use umlet-standalone to view the original uxf diagrams
|
thanks for checking those diagrams. Those changes are needed for reference_integration build as lifecycle blocks building its documentation there. |
We discussed in the last lifecycle meeting that @jaakkoaho will have a look at these changes. |
| .. uml:: model/lifecycle_system_view.puml | ||
| :caption: Lifecycle Manager Application Overview | ||
|
|
||
| AAS Interfaces |
There was a problem hiding this comment.
This is relics of Adaptive Autosar world, this can be removed
| * Access persistent storage to read/lookup configuration | ||
| * Search for/start searching for other service instances to be used to provide application services | ||
|
|
||
| * Note: These operations must not be performed in a blocking manner! Otherwise the predefined maximum amount of time to be spent in machine state ``Initializing`` might be exceeded and the ECU will restart immediately once that becomes the case. |
There was a problem hiding this comment.
time to be spent in machine state Initializing might be exceeded and the ECU will restart immediately once that becomes the case.
This is quite fuzzy and may indicate a project specific behavior
| Introduction | ||
| ------------ | ||
|
|
||
| Purpose of ``score::mw::lifecycle::LifecycleManager`` component is to have a layer of abstraction, that unifies API, for execution managers. |
There was a problem hiding this comment.
execution managers
Is an ARA term, maybe some other wording would be better here? (application lauch manager)?
| POSIX signals | ||
| ~~~~~~~~~~~~~ | ||
|
|
||
| SIGTERM |
There was a problem hiding this comment.
I think the implementation also blocks all other signals than the SIGTERM. I think it would be good to check if this still the case and document it here
|
|
||
| class "mw:LifecycleManager" as LifecycleManager #FFFF00 | ||
|
|
||
| class "Execution Manager" as ExecMgr |
There was a problem hiding this comment.
Execution Manager is an ARA term, I guess this should be changed


Please double check diagrams, as I used AI to convert them into PlantUML and they were not rendered anywhere for comparison.
Bugfix
Important
Use this template only for bugfixes that do not influence topics covered by contribution requests or improvements.
Caution
Make sure to submit your pull-request as Draft until you are ready to have it reviewed by the Committers.
Description
[A short description of the bug being fixed by the contribution.]
Related ticket
Important
Please replace
[ISSUE-NUMBER]with the issue-number that tracks this bug fix. If there is no suchticket yet, create one via this issue template.
closes [ISSUE-NUMBER] (bugfix ticket)