Rust::com General Optimization and cleanup of RUST-API#276
Merged
castler merged 6 commits intoeclipse-score:mainfrom Apr 22, 2026
Merged
Rust::com General Optimization and cleanup of RUST-API#276castler merged 6 commits intoeclipse-score:mainfrom
castler merged 6 commits intoeclipse-score:mainfrom
Conversation
bharatGoswami8
changed the title
bharatGoswami8
force-pushed
the
com_api_optimization
branch
3 times, most recently
from
a8502a3 to
9219844
Compare
bharatGoswami8
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
bharatGoswami8
force-pushed
the
com_api_optimization
branch
3 times, most recently
from
7bd3067 to
6fb410c
Compare
arvindr19
reviewed
Apr 14, 2026
bharatGoswami8
force-pushed
the
com_api_optimization
branch
2 times, most recently
from
247b5d1 to
c49490e
Compare
bharatGoswami8
force-pushed
the
com_api_optimization
branch
2 times, most recently
from
373ba6f to
9a91b18
Compare
| pub skeleton_event: NativeSkeletonEventBase, | ||
| pub _data: PhantomData<T>, | ||
| pub _skeleton_instance: SkeletonInstanceManager, | ||
| _identifier: String, |
Contributor
There was a problem hiding this comment.
This one doesn't seem to be used. Why is it there?
Contributor
Author
There was a problem hiding this comment.
Yes we are directly passing identifier to FFI call and after that we are not using, removed now.
bharatGoswami8
force-pushed
the
com_api_optimization
branch
from
9a91b18 to
cb74c8e
Compare
* Changed init flag from automic to std::once
* Changed NativeSkeletonHandle to NonNull
* Updated Naming for Lola and Mock runtime internal type
* Consumer proxy and event type field updated to NonNull
* Updated receive algo document
* Address the review comment
bharatGoswami8
force-pushed
the
com_api_optimization
branch
from
cb74c8e to
5626a72
Compare
darkwisebear
approved these changes
Apr 21, 2026
castler
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.