Skip to content

Commit 5d173d4

Browse files
committed
Replace score::cpp with std for tracing
- Replace score::cpp::optional with std::optional in all tracing interfaces, mocks, and tests - Add std::optional to score::cpp::optional conversion bridge in tracing_runtime.cpp for baselibs API compatibility - Replace static_cast<EventIdType/FieldIdType>() with brace init EventIdType{}/FieldIdType{} in lola tracing runtime and test - Migrate to StdVariantType with EventId{} struct wrapper - Revert std::get_if/std::get to score::cpp::get_if/score::cpp::get where MetaInfoVariants::Type (score::cpp::variant) is used - Remove #include <score/optional.hpp>, add #include <optional>
1 parent 5c233a9 commit 5d173d4

20 files changed

Lines changed: 136 additions & 135 deletions

score/mw/com/impl/bindings/lola/tracing/tracing_runtime.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ void TracingRuntime::CacheFileDescriptorForReregisteringShmObject(
226226
}
227227
}
228228

229-
score::cpp::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>
229+
std::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>
230230
TracingRuntime::GetCachedFileDescriptorForReregisteringShmObject(
231231
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view) const noexcept
232232
{
@@ -290,12 +290,12 @@ analysis::tracing::ServiceInstanceElement TracingRuntime::ConvertToTracingServic
290290
if (service_element_type == impl::ServiceElementType::EVENT)
291291
{
292292
const auto lola_event_id = lola_service_type_deployment->events_.at(std::string{service_element_name});
293-
output_service_instance_element.element_id = static_cast<ServiceInstanceElement::EventIdType>(lola_event_id);
293+
output_service_instance_element.element_id = ServiceInstanceElement::EventIdType{lola_event_id};
294294
}
295295
else if (service_element_type == impl::ServiceElementType::FIELD)
296296
{
297297
const auto lola_field_id = lola_service_type_deployment->fields_.at(std::string{service_element_name});
298-
output_service_instance_element.element_id = static_cast<ServiceInstanceElement::FieldIdType>(lola_field_id);
298+
output_service_instance_element.element_id = ServiceInstanceElement::FieldIdType{lola_field_id};
299299
}
300300
else
301301
{
@@ -322,7 +322,7 @@ analysis::tracing::ServiceInstanceElement TracingRuntime::ConvertToTracingServic
322322
return output_service_instance_element;
323323
}
324324

325-
score::cpp::optional<analysis::tracing::ShmObjectHandle> TracingRuntime::GetShmObjectHandle(
325+
std::optional<analysis::tracing::ShmObjectHandle> TracingRuntime::GetShmObjectHandle(
326326
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view) const noexcept
327327
{
328328
impl::tracing::ServiceElementInstanceIdentifierView lolaBindingSpecificIdentifier =
@@ -336,7 +336,7 @@ score::cpp::optional<analysis::tracing::ShmObjectHandle> TracingRuntime::GetShmO
336336
return find_result->second.first;
337337
}
338338

339-
score::cpp::optional<void*> TracingRuntime::GetShmRegionStartAddress(
339+
std::optional<void*> TracingRuntime::GetShmRegionStartAddress(
340340
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view) const noexcept
341341
{
342342
impl::tracing::ServiceElementInstanceIdentifierView simplifiedIdentifier =

score/mw/com/impl/bindings/lola/tracing/tracing_runtime.h

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
#include "score/language/safecpp/scoped_function/scope.h"
2424
#include "score/memory/shared/i_shared_memory_resource.h"
2525

26-
#include <score/optional.hpp>
27-
2826
#include <cstddef>
2927
#include <mutex>
3028
#include <optional>
@@ -102,11 +100,11 @@ class TracingRuntime : public impl::tracing::IBindingTracingRuntime
102100
void UnregisterShmObject(const impl::tracing::ServiceElementInstanceIdentifierView&
103101
service_element_instance_identifier_view) noexcept override;
104102

105-
score::cpp::optional<analysis::tracing::ShmObjectHandle> GetShmObjectHandle(
103+
std::optional<analysis::tracing::ShmObjectHandle> GetShmObjectHandle(
106104
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view)
107105
const noexcept override;
108106

109-
score::cpp::optional<void*> GetShmRegionStartAddress(
107+
std::optional<void*> GetShmRegionStartAddress(
110108
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view)
111109
const noexcept override;
112110

@@ -115,7 +113,7 @@ class TracingRuntime : public impl::tracing::IBindingTracingRuntime
115113
const memory::shared::ISharedMemoryResource::FileDescriptor shm_file_descriptor,
116114
void* const shm_memory_start_address) noexcept override;
117115

118-
score::cpp::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>
116+
std::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>
119117
GetCachedFileDescriptorForReregisteringShmObject(
120118
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view)
121119
const noexcept override;
@@ -151,7 +149,7 @@ class TracingRuntime : public impl::tracing::IBindingTracingRuntime
151149
// Suppress "AUTOSAR C++14 M11-0-1" rule findings. This rule states: "Member data in non-POD class types shall
152150
// be private.". We need these data elements to be organized into a coherent organized data structure.
153151
// coverity[autosar_cpp14_m11_0_1_violation]
154-
score::cpp::optional<impl::tracing::TypeErasedSamplePtr> sample_ptr;
152+
std::optional<impl::tracing::TypeErasedSamplePtr> sample_ptr;
155153
// coverity[autosar_cpp14_m11_0_1_violation]
156154
std::mutex mutex;
157155
};
@@ -170,7 +168,7 @@ class TracingRuntime : public impl::tracing::IBindingTracingRuntime
170168
-> std::optional<TraceContextId>;
171169

172170
const Configuration& configuration_;
173-
score::cpp::optional<analysis::tracing::TraceClientId> trace_client_id_;
171+
std::optional<analysis::tracing::TraceClientId> trace_client_id_;
174172
bool data_loss_flag_;
175173

176174
/// \brief Array of type erased sample pointers containing one element per service element that registers itself via

score/mw/com/impl/bindings/lola/tracing/tracing_runtime_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,13 +1035,13 @@ TEST_F(TracingRuntimeConvertToTracingServiceInstanceElementFixture,
10351035
major_version_number_,
10361036
minor_version_number_,
10371037
static_cast<ServiceInstanceElement::InstanceIdType>(instance_id_),
1038-
static_cast<ServiceInstanceElement::EventIdType>(event_id_)};
1038+
ServiceInstanceElement::EventIdType{event_id_}};
10391039
const ServiceInstanceElement expected_service_instance_element_field{
10401040
static_cast<ServiceInstanceElement::ServiceIdType>(service_id_),
10411041
major_version_number_,
10421042
minor_version_number_,
10431043
static_cast<ServiceInstanceElement::InstanceIdType>(instance_id_),
1044-
static_cast<ServiceInstanceElement::FieldIdType>(field_id_)};
1044+
ServiceInstanceElement::FieldIdType{field_id_}};
10451045

10461046
// Given a TracingRuntimeObject with a provided configuration object
10471047
TracingRuntime tracing_runtime{kNumberOfTotalConfiguredTracingSlots, configuration};

score/mw/com/impl/bindings/mock_binding/tracing/tracing_runtime.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ class TracingRuntime : public IBindingTracingRuntime
3636
UnregisterShmObject,
3737
(const impl::tracing::ServiceElementInstanceIdentifierView&),
3838
(noexcept, override));
39-
MOCK_METHOD(score::cpp::optional<analysis::tracing::ShmObjectHandle>,
39+
MOCK_METHOD(std::optional<analysis::tracing::ShmObjectHandle>,
4040
GetShmObjectHandle,
4141
(const impl::tracing::ServiceElementInstanceIdentifierView&),
4242
(const, noexcept, override));
43-
MOCK_METHOD(score::cpp::optional<void*>,
43+
MOCK_METHOD(std::optional<void*>,
4444
GetShmRegionStartAddress,
4545
(const impl::tracing::ServiceElementInstanceIdentifierView&),
4646
(const, noexcept, override));
@@ -50,7 +50,7 @@ class TracingRuntime : public IBindingTracingRuntime
5050
memory::shared::ISharedMemoryResource::FileDescriptor,
5151
void*),
5252
(noexcept, override));
53-
MOCK_METHOD((score::cpp::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>),
53+
MOCK_METHOD((std::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>),
5454
GetCachedFileDescriptorForReregisteringShmObject,
5555
(const impl::tracing::ServiceElementInstanceIdentifierView&),
5656
(const, noexcept, override));

score/mw/com/impl/tracing/common_event_tracing.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ ResultBlank TraceData(const ServiceElementInstanceIdentifierView service_element
4646
const TracingRuntime::TracePointType trace_point,
4747
const BindingType binding_type,
4848
const std::pair<const void*, std::size_t>& local_data_chunk,
49-
const score::cpp::optional<TracingRuntime::TracePointDataId> trace_point_data_id) noexcept
49+
const std::optional<TracingRuntime::TracePointDataId> trace_point_data_id) noexcept
5050
{
5151
auto* const tracing_runtime = impl::Runtime::getInstance().GetTracingRuntime();
5252
SCORE_LANGUAGE_FUTURECPP_ASSERT_PRD(tracing_runtime != nullptr);

score/mw/com/impl/tracing/common_event_tracing.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@
1818
#include "score/mw/com/impl/tracing/configuration/service_element_instance_identifier_view.h"
1919
#include "score/mw/com/impl/tracing/tracing_runtime.h"
2020

21-
#include <score/optional.hpp>
22-
2321
#include <cstdint>
22+
#include <optional>
2423
#include <string_view>
2524
#include <utility>
2625

@@ -39,7 +38,7 @@ ResultBlank TraceData(const ServiceElementInstanceIdentifierView service_element
3938
const TracingRuntime::TracePointType trace_point,
4039
const BindingType binding_type,
4140
const std::pair<const void*, std::size_t>& local_data_chunk = {nullptr, 0U},
42-
const score::cpp::optional<TracingRuntime::TracePointDataId> trace_point_data_id = {}) noexcept;
41+
const std::optional<TracingRuntime::TracePointDataId> trace_point_data_id = {}) noexcept;
4342

4443
ResultBlank TraceShmData(const BindingType binding_type,
4544
const ServiceElementTracingData service_element_tracing_data,

score/mw/com/impl/tracing/common_event_tracing_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ TEST_F(CommonEventTracingLocalTraceDataFixture, CallingTraceDataWillDispatchToBi
119119
Trace(binding_type_,
120120
service_element_instance_identifier_view_,
121121
trace_point_,
122-
score::cpp::optional<TracingRuntime::TracePointDataId>{trace_point_data_id_},
122+
std::optional<TracingRuntime::TracePointDataId>{trace_point_data_id_},
123123
local_data_chunk_.first,
124124
local_data_chunk_.second));
125125

score/mw/com/impl/tracing/configuration/tracing_filter_config_test.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include <cstddef>
1919
#include <cstdint>
2020
#include <limits>
21+
#include <optional>
2122
#include <string>
2223
#include <string_view>
2324

@@ -33,7 +34,7 @@ const std::string kEventName{"my_event_name"};
3334
const std::string kFieldName{"my_field_name"};
3435
const auto kInstanceSpecifiersv = "abc/abc/TirePressurePort"sv;
3536
const ITracingFilterConfig::InstanceSpecifierView kInstanceSpecifierView{"my_instance_specifier"};
36-
const score::cpp::optional<ITracingFilterConfig::InstanceSpecifierView> kEnableAllInstanceSpecifiers{};
37+
const std::optional<ITracingFilterConfig::InstanceSpecifierView> kEnableAllInstanceSpecifiers{};
3738
constexpr auto kDummyTracePointType = SkeletonEventTracePointType::SEND;
3839

3940
// Trace point type constants
@@ -705,7 +706,7 @@ class ConfigurationFixture : public ::testing::Test
705706
PrepareMinimalConfiguration(valid_instance_specifier, service_type_, events, fields);
706707
}
707708

708-
score::cpp::optional<Configuration> configuration_{};
709+
std::optional<Configuration> configuration_{};
709710
TracingFilterConfig tracing_filter_config_{};
710711
const std::string_view service_type_ = "/score/ncar/services/TirePressureService";
711712
const std::string event_name_ = "CurrentPressureFrontLeft";

score/mw/com/impl/tracing/i_binding_tracing_runtime.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
#include "score/mw/com/impl/tracing/type_erased_sample_ptr.h"
2222

2323
#include <score/callback.hpp>
24-
#include <score/optional.hpp>
2524

2625
#include <cstdint>
26+
#include <optional>
2727

2828
namespace score::mw::com::impl::tracing
2929
{
@@ -84,18 +84,18 @@ class IBindingTracingRuntime
8484
virtual void UnregisterShmObject(const impl::tracing::ServiceElementInstanceIdentifierView&
8585
service_element_instance_identifier_view) noexcept = 0;
8686

87-
virtual score::cpp::optional<analysis::tracing::ShmObjectHandle> GetShmObjectHandle(
87+
virtual std::optional<analysis::tracing::ShmObjectHandle> GetShmObjectHandle(
8888
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view)
8989
const noexcept = 0;
90-
virtual score::cpp::optional<void*> GetShmRegionStartAddress(
90+
virtual std::optional<void*> GetShmRegionStartAddress(
9191
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view)
9292
const noexcept = 0;
9393

9494
virtual void CacheFileDescriptorForReregisteringShmObject(
9595
const impl::tracing::ServiceElementInstanceIdentifierView& service_element_instance_identifier_view,
9696
const memory::shared::ISharedMemoryResource::FileDescriptor shm_file_descriptor,
9797
void* const shm_memory_start_address) noexcept = 0;
98-
virtual score::cpp::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>
98+
virtual std::optional<std::pair<memory::shared::ISharedMemoryResource::FileDescriptor, void*>>
9999
GetCachedFileDescriptorForReregisteringShmObject(const impl::tracing::ServiceElementInstanceIdentifierView&
100100
service_element_instance_identifier_view) const noexcept = 0;
101101
virtual void ClearCachedFileDescriptorForReregisteringShmObject(

score/mw/com/impl/tracing/i_tracing_runtime.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include "score/result/result.h"
2727

2828
#include <cstdint>
29+
#include <optional>
2930
#include <variant>
3031

3132
namespace score::mw::com::impl::tracing
@@ -72,7 +73,7 @@ class ITracingRuntime
7273
virtual ResultBlank Trace(const BindingType binding_type,
7374
const ServiceElementInstanceIdentifierView service_element_instance_identifier,
7475
const TracePointType trace_point_type,
75-
const score::cpp::optional<TracePointDataId> trace_point_data_id,
76+
const std::optional<TracePointDataId> trace_point_data_id,
7677
const void* const local_data_ptr,
7778
const std::size_t local_data_size) noexcept = 0;
7879

0 commit comments

Comments
 (0)