Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TabFolderLayout into SWT and set it as a default in TabFolder #1317

Closed
laeubi opened this issue Jul 3, 2024 · 0 comments · Fixed by #1402, eclipse-platform/eclipse.platform.ui#2186, eclipse-platform/eclipse.platform#1595 or eclipse-pde/eclipse.pde#1452
Closed

Move TabFolderLayout into SWT and set it as a default in TabFolder #1317

laeubi opened this issue Jul 3, 2024 · 0 comments · Fixed by #1402, eclipse-platform/eclipse.platform.ui#2186, eclipse-platform/eclipse.platform#1595 or eclipse-pde/eclipse.pde#1452

Comments

@laeubi
Copy link
Contributor

laeubi commented Jul 3, 2024

Today I debugged some issues with TabFolder and noticed that it at least behaves strange if tabs are added dynamically, after investigate a little bit more I tried to fix it with an own Layout as usual layout mangers (like FillLayout) get sometimes confused as TabFolder has more childs than are actually displayed.

Short after that I noticed that there are already some instances of TabFolderLayout in platform:
grafik

They all seem to be copies of each other (more or less) except the license header and when they where added, I therefore wonder if we should simply add that layout to SWT and even set it by default to TabFolder.
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Aug 13, 2024
@deepika-u
Moving TabFolderLayout into SWT.
042f89a 
Fixes eclipse-platform#1317
@deepika-u deepika-u mentioned this issue Aug 13, 2024
Merged
@laeubi laeubi mentioned this issue Aug 13, 2024
Merged
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Aug 13, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
4fb86d8 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Aug 16, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
489204f 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Aug 20, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
6959382 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Sep 2, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
537c9fb 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Sep 16, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
dcfa741 
Fixes eclipse-platform#1317
laeubi pushed a commit to deepika-u/eclipse.platform.swt that referenced this issue Sep 17, 2024
@deepika-u @laeubi
Moving TabFolderLayout into SWT. Updated as per review comments.
c3114f3 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Sep 18, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
9e60276 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Sep 19, 2024
@deepika-u
Moving TabFolderLayout into SWT. Incorporated review comments.
9143720 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Sep 19, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
b63abcd 
Fixes eclipse-platform#1317
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Sep 20, 2024
@deepika-u
Moving TabFolderLayout into SWT. Updated as per review comments.
314211c 
Fixes eclipse-platform#1317
akurtakov pushed a commit to deepika-u/eclipse.platform.swt that referenced this issue Oct 4, 2024
@deepika-u @akurtakov
Moving TabFolderLayout into SWT. Updated as per review comments.
08ab223 
Fixes eclipse-platform#1317
akurtakov pushed a commit that referenced this issue Oct 7, 2024
@deepika-u @akurtakov
Moving TabFolderLayout into SWT. Updated as per review comments.
0324a13 
Fixes #1317
deepika-u added a commit to deepika-u/eclipse.platform that referenced this issue Oct 23, 2024
@deepika-u
Moving TabFolderLayout into SWT to have a single copy.
e428655 
Fixes eclipse-platform/eclipse.platform.swt#1317
@deepika-u deepika-u mentioned this issue Oct 23, 2024
Merged
deepika-u added a commit to deepika-u/eclipse.pde that referenced this issue Oct 23, 2024
@deepika-u
Moving TabFolderLayout into SWT to have a single copy.
6c7dcc1 
Fixes eclipse-platform/eclipse.platform.swt#1317
@deepika-u deepika-u mentioned this issue Oct 23, 2024
Merged
deepika-u added a commit to deepika-u/eclipse.pde that referenced this issue Oct 23, 2024
@deepika-u
Moving TabFolderLayout into SWT to have a single copy.
64cf6f7 
Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT.
9dc2470 
Fixes eclipse-platform#1317

Moving TabFolderLayout into SWT. Incorporated review comments.

Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT.
c5c35ba 
Fixes eclipse-platform#1317

Moving TabFolderLayout into SWT. Incorporated review comments.

Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.pde that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT to have a single copy.
63d3f21 
Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT.
ad75d6b 
Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT.
3069cf4 
Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.platform that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT to have a single copy.
cb8da0c 
Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.platform that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT to have a single copy.
b3ab33d 
Fixes eclipse-platform/eclipse.platform.swt#1317
deepika-u added a commit to deepika-u/eclipse.platform.ui that referenced this issue Oct 24, 2024
@deepika-u
Moving TabFolderLayout into SWT.
6bb53db 
Fixes eclipse-platform/eclipse.platform.swt#1317
akurtakov pushed a commit to eclipse-pde/eclipse.pde that referenced this issue Oct 24, 2024
@deepika-u @akurtakov
Moving TabFolderLayout into SWT to have a single copy.
dfe2720 
Fixes eclipse-platform/eclipse.platform.swt#1317
akurtakov pushed a commit to eclipse-platform/eclipse.platform.ui that referenced this issue Oct 24, 2024
@deepika-u @akurtakov
Moving TabFolderLayout into SWT.
3b49502 
Fixes eclipse-platform/eclipse.platform.swt#1317
akurtakov pushed a commit to eclipse-platform/eclipse.platform that referenced this issue Oct 24, 2024
@deepika-u @akurtakov
Moving TabFolderLayout into SWT to have a single copy.
78c13b5 
Fixes eclipse-platform/eclipse.platform.swt#1317
merks added a commit to merks/eclipse.platform.ui that referenced this issue Oct 25, 2024
@merks
Increment to 3.207.0 because reported org.eclipse.swt changed ranges
c208a9b 
eclipse-platform/eclipse.platform.swt#1317
@merks merks mentioned this issue Oct 25, 2024
Merged
merks added a commit to merks/eclipse.platform.ui that referenced this issue Oct 25, 2024
@merks
Increment to 3.207.0 because re-exported org.eclipse.swt changed ranges
f682c2a 
eclipse-platform/eclipse.platform.swt#1317
merks added a commit to eclipse-platform/eclipse.platform.ui that referenced this issue Oct 25, 2024
@merks
Increment to 3.207.0 because re-exported org.eclipse.swt changed ranges
e43dec2 
eclipse-platform/eclipse.platform.swt#1317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@laeubi