Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users of the Find/Replace dialog want to use Alt + A to perform "Search all" #2080

Closed
Tracked by #2021
Wittmaxi opened this issue Jul 15, 2024 · 1 comment
Closed
Tracked by #2021

Users of the Find/Replace dialog want to use Alt + A to perform "Search all" #2080

Wittmaxi opened this issue Jul 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Wittmaxi
Copy link
Contributor

Wittmaxi commented Jul 15, 2024 •
edited
Loading

Some users are used to pressing "Alt+A" to perform search all which was a mnemonic used in the FindReplaceDialog.
Those users should be able to press Alt+A in the Overlay as well so that they don't need to "learn" new key combinations

This issue was originally brought up by user u/n4te on reddit
@Wittmaxi Wittmaxi added the enhancement New feature or request label Jul 15, 2024
@HeikoKlare HeikoKlare mentioned this issue Jul 16, 2024
Open
64 tasks
@Wittmaxi Wittmaxi mentioned this issue Jul 16, 2024
Merged
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Sep 2, 2024
@Wittmaxi
FindReplaceOverlay: add support from mnemonics from the Dialog
5f931ee 
In order to preserve the workflow of users who use the Mnemonics of the
Find/Replace Dialog a lot, add support to these key combinations as well

fixes eclipse-platform#2080
@Wittmaxi Wittmaxi mentioned this issue Sep 2, 2024
Closed
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Oct 16, 2024
@Wittmaxi
FindReplaceOverlay: add support from mnemonics from the Dialog
b2610b5 
In order to preserve the workflow of users who use the Mnemonics of the
Find/Replace Dialog a lot, add support to these key combinations as well

fixes eclipse-platform#2080
@HeikoKlare
Copy link
Contributor

There are already shortcuts for the search options, which should also be made configurable in the future (#2015). In order to not pollute the editors/overlay with shortcuts (in particular after #2254 and since they are currently not configurably mapped to actions and thus may be conflicting with other actions), we agreed to not implement this but rather keep the shortcuts that are explicitly defined and visible (in tooltips) and improve the possibilities with customizability of the shortcuts.

@HeikoKlare HeikoKlare closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FindReplaceOverlay: add support from mnemonics from the Dialog Wittmaxi/eclipse.platform.ui
2 participants
@HeikoKlare @Wittmaxi