Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK][HiDpi] Code cleanup for removal of non-cairo scale path #1300

Open
deepika-u opened this issue Jun 24, 2024 · 3 comments · May be fixed by #1304
Open

[GTK][HiDpi] Code cleanup for removal of non-cairo scale path #1300

deepika-u opened this issue Jun 24, 2024 · 3 comments · May be fixed by #1304
Assignees
@deepika-u

Comments

@deepika-u
Copy link
Contributor

deepika-u commented Jun 24, 2024 •
edited
Loading

Currently we are using cairo for image operations we don't use non cairo scale path anymore.
Its better to remove that path now.

Environment:

  1. Select the platform(s) on which the behavior is seen:
    • All OS
    • Windows
    • Linux
    • macOS

Additional context
https://bugs.eclipse.org/bugs/show_bug.cgi?id=569233#c5

@SyntevoAlex @akurtakov @merks
Please do let us know if you have any objection/suggestion for proceeding on this issue.

@sravanlakkimsetti
Please do let me know your opinion on this.
@akurtakov
Copy link
Member

If it's truly unused code path I'm all for removing it.

@sravanlakkimsetti
Copy link
Member

If it's truly unused code path I'm all for removing it.

Its unused now. The last platform that used this path was Ubuntu 18.04 with KDE (Kubuntu). Ubuntu 18.04 went out of support in 2023. So no need of keeping this path now.

@SyntevoAlex
Copy link
Member

No objections from my side.

deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Jun 26, 2024
@deepika-u
[GTK][HiDpi] Code cleanup for removal of non-cairo scale path
cf1b492 
Fixes eclipse-platform#1300
@deepika-u deepika-u linked a pull request Jun 26, 2024 that will close this issue
Draft
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Jun 26, 2024
@deepika-u
[GTK][HiDpi] Code cleanup for removal of non-cairo scale path
ba087cb 
Fixes eclipse-platform#1300
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Jun 26, 2024
@deepika-u
[GTK][HiDpi] Code cleanup for removal of non-cairo scale path
15788c0 
Fixes eclipse-platform#1300
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Jun 26, 2024
@deepika-u
[GTK][HiDpi] Code cleanup for removal of non-cairo scale path
1a73f3b 
Fixes eclipse-platform#1300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepika-u deepika-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GTK][HiDpi] Code cleanup for removal of non-cairo scale path deepika-u/eclipse.platform.swt
4 participants
@akurtakov @SyntevoAlex @deepika-u @sravanlakkimsetti