[Build] Simplify exclusion of artifacts during Maven publication and inline CBIaggregator script #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
maven-publication-simplify-aggregation
branch
2 times, most recently
from
5d391e9 to
78d4b59
Compare
Instead of actively deleting undesired artifacts and collecting the resulting garbage by deleting all then unused dependencies, just skip the validation and deployment of undesired artifacts from the folders of the published projects/groups.
Inlining the script allows to integrate its commands tighter with the pipeline and to reuse the existing facilities to download required tools. Additionally simplify the configuration of the tool-setup by deriving the versions of the eclipse-tools from the 'PREVIOUS_RELEASE' properties declared in 'cje-production/buildproperties.txt'.
Collect the artifacts to publish and their paths once after the aggregation is completed and reuse that list for validation and the actual deployment. This also simplifies tracing the list of published artifacts.
HannesWell
force-pushed
the
maven-publication-simplify-aggregation
branch
from
78d4b59 to
0dd08bd
Compare
|
After a lot of testing and more refinements this is now ready for submission. The verification build doesn't test this, therefore I submit this immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the workflow for publication to Maven in the following two steps:
Instead of activly deleting not desired artifacts and collecting the resulting garbage by deleting all then unused dependencies, just skip the validation and deployment of undesired artifacts from the folders of the published projects/groups.
Inlining the script allows to integrate its commands tighter with the pipeline and to reuse the existing facilities to download required tools.
Additionally simplify the configuration of the tool-setup by deriving the versions of the eclipse-tools from the
PREVIOUS_RELEASEproperties declared in thebuildproperties.propertiesfile of the latest I-build.This is currently a draft since a few things have to be tested, but the general form is already ready.