Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the PDE Export Wizards for products, features, bundles and categories using P2 #862

Open
laeubi opened this issue Nov 2, 2023 · 3 comments
Labels
technical debt An actual or contingent liability whose impact is limited to internal system qualities.

Comments

@laeubi
Copy link
Contributor

laeubi commented Nov 2, 2023

The PDE Export Wizards are initially based on the PDE Build Ant infrastructure but was not maintained for a long time and now that PDE build is even abandoned they started to fall behind more and more for recent features. For category.xml we even miss an export feature completely.

Another problem is that these often fail in complex setups with strange errors and lack a way to report proper problems, while the IDE build itself looks fine and works.

To get en par with Tycho and not confuse users with rotten functionality I therefore suggest to rework the function to use P2 instead as this is what Tycho is using under the hood and is therefore updated when we support new features and is currently maintained by the platform already.

Such a solution should include

  • Adjustment for export of "Deployable plug-ins and fragments"
  • Adjustment for export of "Deployable features"
  • Adjustments for export of "Eclipse product"
  • Adding support for "Categorized Items" (aka category.xml)

For features that can't be expressed in the new world (especially "Save as Ant script") there should be the option for the user to enable a "Legacy Mode" where the old code is used but with a strong warning that this is unsupported, like we already do in the source repository to encourage users to upgrade.

@laeubi laeubi added the technical debt An actual or contingent liability whose impact is limited to internal system qualities. label Nov 2, 2023
@HannesWell
Copy link
Member

I fully support his and already thought multiple times that this is the way forward.

  • Adjustment for export of "Deployable plug-ins and fragments"

A specific detail that I thought about for this part is that in case one configures the export to not use the class files from the workspace, it would be nice to be able to select from the available VM-installs one that should be used for compilation (I assume the ANT-tasks use javac in that case at the moment).

@akurtakov
Copy link
Member

That would be very welcome change .

@haubi
Copy link
Contributor

haubi commented Feb 26, 2024

For the records: Eclipse TEA, when installed together with Launch Config DSL, is able to 'Create Update Site from Feature...', both within Eclipse GUI as well as headless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt An actual or contingent liability whose impact is limited to internal system qualities.
Projects
None yet
Development

No branches or pull requests

4 participants