Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: enable JIT compilation of more methods under FSD #20969

Open
JamesKingdon opened this issue Jan 17, 2025 · 2 comments
Open

Feature request: enable JIT compilation of more methods under FSD #20969

JamesKingdon opened this issue Jan 17, 2025 · 2 comments

Comments

@JamesKingdon
Copy link
Contributor

JamesKingdon commented Jan 17, 2025

When running in FSD mode the JIT fails to compile certain methods containing method handles. The resulting time spent in the interpreter for these methods can cause a significant performance difference compared to not running in FSD. This obviously impacts developer experience when needing to run significant code before reaching the code to be debugged.

(Mistaken statements about agents removed)

@jdmpapin
Copy link
Contributor

wider consequences with the increasing prevalence of agents that late attach and therefore need to perform class redefinition.

I don't think I understand the connection here. For quite a few years now it has been possible by default for an agent to late attach and redefine classes. This doesn't require debug mode

@JamesKingdon
Copy link
Contributor Author

JamesKingdon commented Jan 17, 2025

I'd have to go back over my notes, but I'm reasonably confident that one of the recent cases related to running in FSD as a result of class redef.

Went back over my notes, I was wrong. The case was caused by the combination of FSD and the late attached agent, not FSD being caused by the agent doing redef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants