Skip to content

Commit 681725e

Browse files
committed
Fix unnamed module spelling mistake
Signed-off-by: Nathan Henderson <[email protected]>
1 parent 26133ff commit 681725e

17 files changed

+46
-46
lines changed

runtime/gc_base/RootScanner.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ MM_RootScanner::scanModularityObjects(J9ClassLoader * classLoader)
102102
}
103103

104104
if (classLoader == _javaVM->systemClassLoader) {
105-
doSlot(&_javaVM->unamedModuleForSystemLoader->moduleObject);
105+
doSlot(&_javaVM->unnamedModuleForSystemLoader->moduleObject);
106106
}
107107
}
108108
}

runtime/gc_glue_java/ConcurrentMarkingDelegate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ MM_ConcurrentMarkingDelegate::concurrentClassMark(MM_EnvironmentBase *env, bool
439439
}
440440

441441
if (classLoader == _javaVM->systemClassLoader) {
442-
_markingScheme->markObject(env, _javaVM->unamedModuleForSystemLoader->moduleObject);
442+
_markingScheme->markObject(env, _javaVM->unnamedModuleForSystemLoader->moduleObject);
443443
}
444444
}
445445

runtime/gc_glue_java/MarkingDelegate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ MM_MarkingDelegate::completeMarking(MM_EnvironmentBase *env)
425425
}
426426

427427
if (classLoader == javaVM->systemClassLoader) {
428-
_markingScheme->markObjectNoCheck(env, (omrobjectptr_t )javaVM->unamedModuleForSystemLoader->moduleObject);
428+
_markingScheme->markObjectNoCheck(env, (omrobjectptr_t )javaVM->unnamedModuleForSystemLoader->moduleObject);
429429
}
430430
}
431431
}

runtime/gc_glue_java/MetronomeDelegate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1046,7 +1046,7 @@ MM_MetronomeDelegate::doClassTracing(MM_EnvironmentRealtime *env)
10461046
}
10471047

10481048
if (classLoader == _javaVM->systemClassLoader) {
1049-
didWork |= _markingScheme->markObject(env, _javaVM->unamedModuleForSystemLoader->moduleObject);
1049+
didWork |= _markingScheme->markObject(env, _javaVM->unnamedModuleForSystemLoader->moduleObject);
10501050
}
10511051
}
10521052
}

runtime/gc_vlhgc/CopyForwardScheme.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2697,7 +2697,7 @@ MM_CopyForwardScheme::scanClassLoaderObjectSlots(MM_EnvironmentVLHGC *env, MM_Al
26972697
}
26982698

26992699
if (success && (classLoader == _javaVM->systemClassLoader)) {
2700-
success = copyAndForward(env, reservingContext, classLoaderObject, (J9Object **)&(_javaVM->unamedModuleForSystemLoader->moduleObject));
2700+
success = copyAndForward(env, reservingContext, classLoaderObject, (J9Object **)&(_javaVM->unnamedModuleForSystemLoader->moduleObject));
27012701
}
27022702
}
27032703
}
@@ -4447,7 +4447,7 @@ MM_CopyForwardScheme::scanRoots(MM_EnvironmentVLHGC* env)
44474447
}
44484448

44494449
if (success && (classLoader == _javaVM->systemClassLoader)) {
4450-
success = copyAndForward(env, getContextForHeapAddress(_javaVM->unamedModuleForSystemLoader->moduleObject), (J9Object **)&(_javaVM->unamedModuleForSystemLoader->moduleObject));
4450+
success = copyAndForward(env, getContextForHeapAddress(_javaVM->unnamedModuleForSystemLoader->moduleObject), (J9Object **)&(_javaVM->unnamedModuleForSystemLoader->moduleObject));
44514451
}
44524452
}
44534453
}

runtime/gc_vlhgc/GlobalMarkCardScrubber.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,9 +299,9 @@ MM_GlobalMarkCardScrubber::scrubClassLoaderObject(MM_EnvironmentVLHGC *env, J9Ob
299299
}
300300

301301
if (classLoader == javaVM->systemClassLoader) {
302-
Assert_MM_true(NULL != javaVM->unamedModuleForSystemLoader->moduleObject);
302+
Assert_MM_true(NULL != javaVM->unnamedModuleForSystemLoader->moduleObject);
303303
if (doScrub) {
304-
doScrub = mayScrubReference(env, classLoaderObject, javaVM->unamedModuleForSystemLoader->moduleObject);
304+
doScrub = mayScrubReference(env, classLoaderObject, javaVM->unnamedModuleForSystemLoader->moduleObject);
305305
}
306306
}
307307
}

runtime/gc_vlhgc/GlobalMarkingScheme.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -908,9 +908,9 @@ MM_GlobalMarkingScheme::scanClassLoaderObject(MM_EnvironmentVLHGC *env, J9Object
908908
}
909909

910910
if (classLoader == _javaVM->systemClassLoader) {
911-
Assert_MM_true(NULL != _javaVM->unamedModuleForSystemLoader->moduleObject);
912-
markObject(env, _javaVM->unamedModuleForSystemLoader->moduleObject);
913-
rememberReferenceIfRequired(env, classLoaderObject, _javaVM->unamedModuleForSystemLoader->moduleObject);
911+
Assert_MM_true(NULL != _javaVM->unnamedModuleForSystemLoader->moduleObject);
912+
markObject(env, _javaVM->unnamedModuleForSystemLoader->moduleObject);
913+
rememberReferenceIfRequired(env, classLoaderObject, _javaVM->unnamedModuleForSystemLoader->moduleObject);
914914
}
915915
}
916916
}

runtime/gc_vlhgc/WriteOnceCompactor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1359,7 +1359,7 @@ MM_WriteOnceCompactor::fixupClassLoaderObject(MM_EnvironmentVLHGC* env, J9Object
13591359
}
13601360

13611361
if (classLoader == _javaVM->systemClassLoader) {
1362-
slotPtr = &_javaVM->unamedModuleForSystemLoader->moduleObject;
1362+
slotPtr = &_javaVM->unnamedModuleForSystemLoader->moduleObject;
13631363

13641364
originalObject = *slotPtr;
13651365
J9Object* forwardedObject = getForwardWrapper(env, originalObject, cache);

runtime/j9vm/java11vmi.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ static UDATA addModuleDefinition(J9VMThread * currentThread, J9Module * fromModu
7171
static BOOLEAN isPackageDefined(J9VMThread * currentThread, J9ClassLoader * classLoader, const char *packageName);
7272
static BOOLEAN areNoPackagesDefined(J9VMThread * currentThread, J9ClassLoader * classLoader, const char* const* packages, U_32 numPackages);
7373
static UDATA exportPackageToAll(J9VMThread * currentThread, J9Module * fromModule, const char *package);
74-
static UDATA exportPackageToAllUnamed(J9VMThread * currentThread, J9Module * fromModule, const char *package);
74+
static UDATA exportPackageToAllUnnamed(J9VMThread *currentThread, J9Module *fromModule, const char *package);
7575
static UDATA exportPackageToModule(J9VMThread * currentThread, J9Module * fromModule, const char *package, J9Module * toModule);
7676
static void trcModulesCreationPackage(J9VMThread * currentThread, J9Module * fromModule, const char *package);
7777
static void trcModulesAddModuleExportsToAll(J9VMThread * currentThread, J9Module * fromModule, const char *package);
@@ -281,7 +281,7 @@ createModule(J9VMThread * currentThread, j9object_t moduleObject, J9ClassLoader
281281
} else {
282282
if (NULL == moduleName) {
283283
/* moduleName is passed as NULL for the unnamed module for bootloader created by JVM_SetBootLoaderUnnamedModule() */
284-
j9mod = vm->unamedModuleForSystemLoader;
284+
j9mod = vm->unnamedModuleForSystemLoader;
285285
} else {
286286
j9mod = vm->javaBaseModule;
287287
j9mod->isLoose = TRUE;
@@ -561,7 +561,7 @@ trcModulesAddModuleExportsToAllUnnamed(J9VMThread * currentThread, J9Module * fr
561561
}
562562

563563
static UDATA
564-
exportPackageToAllUnamed(J9VMThread * currentThread, J9Module * fromModule, const char *package)
564+
exportPackageToAllUnnamed(J9VMThread * currentThread, J9Module * fromModule, const char *package)
565565
{
566566
UDATA retval = ERRCODE_GENERAL_FAILURE;
567567
J9Package * const j9package = getPackageDefinition(currentThread, fromModule, package, &retval);
@@ -914,9 +914,9 @@ JVM_DefineModule(JNIEnv * env, jobject module, jboolean isOpen, jstring version,
914914
}
915915

916916
#if JAVA_SPEC_VERSION >= 21
917-
/* vm->unamedModuleForSystemLoader->moduleObject was saved by JVM_SetBootLoaderUnnamedModule */
917+
/* vm->unnamedModuleForSystemLoader->moduleObject was saved by JVM_SetBootLoaderUnnamedModule */
918918
{
919-
j9object_t moduleObject = vm->unamedModuleForSystemLoader->moduleObject;
919+
j9object_t moduleObject = vm->unnamedModuleForSystemLoader->moduleObject;
920920
Assert_SC_notNull(moduleObject);
921921
J9VMJAVALANGCLASSLOADER_SET_UNNAMEDMODULE(currentThread, systemClassLoader->classLoaderObject, moduleObject);
922922
Trc_MODULE_defineModule_setBootloaderUnnamedModule(currentThread);
@@ -1022,7 +1022,7 @@ JVM_AddModuleExports(JNIEnv * env, jobject fromModule, const char *package, jobj
10221022
J9Module * const j9ToMod = getJ9Module(currentThread, toModule);
10231023

10241024
if (isModuleUnnamed(currentThread, J9_JNI_UNWRAP_REFERENCE(toModule))) {
1025-
rc = exportPackageToAllUnamed(currentThread, j9FromMod, package);
1025+
rc = exportPackageToAllUnnamed(currentThread, j9FromMod, package);
10261026
} else {
10271027
rc = exportPackageToModule(currentThread, j9FromMod, package, j9ToMod);
10281028
}
@@ -1339,9 +1339,9 @@ JVM_AddModuleExportsToAllUnnamed(JNIEnv * env, jobject fromModule, const char *p
13391339
{
13401340
UDATA rc = ERRCODE_GENERAL_FAILURE;
13411341

1342-
J9Module * const j9FromMod = getJ9Module(currentThread, fromModule);
1342+
J9Module *const j9FromMod = getJ9Module(currentThread, fromModule);
13431343

1344-
rc = exportPackageToAllUnamed(currentThread, j9FromMod, package);
1344+
rc = exportPackageToAllUnnamed(currentThread, j9FromMod, package);
13451345

13461346
if (ERRCODE_SUCCESS != rc) {
13471347
throwExceptionHelper(currentThread, rc);
@@ -1501,7 +1501,7 @@ JVM_WaitForReferencePendingList(JNIEnv *env)
15011501

15021502
/**
15031503
* Adds an unnamed module to the bootLoader
1504-
* JDK21+ saves it to J9JavaVM->unamedModuleForSystemLoader->moduleObject,
1504+
* JDK21+ saves it to J9JavaVM->unnamedModuleForSystemLoader->moduleObject,
15051505
* and delays bootclassloader.unnamedModule setting until java.base module is created.
15061506
*
15071507
* @param module module
@@ -1539,16 +1539,16 @@ JVM_SetBootLoaderUnnamedModule(JNIEnv *env, jobject module)
15391539
vmFuncs->setCurrentExceptionUTF(currentThread, J9VMCONSTANTPOOL_JAVALANGILLEGALARGUMENTEXCEPTION, "module was not loaded by the bootclassloader");
15401540
} else {
15411541
#if JAVA_SPEC_VERSION >= 21
1542-
J9Module *unamedModuleForSystemLoader = vm->unamedModuleForSystemLoader;
1542+
J9Module *unnamedModuleForSystemLoader = vm->unnamedModuleForSystemLoader;
15431543
/* can't set bootclassloader.unnamedModule since bootclassloader hasn't finished the initialization yet */
1544-
if (NULL == unamedModuleForSystemLoader) {
1545-
vmFuncs->setCurrentExceptionUTF(currentThread, J9VMCONSTANTPOOL_JAVALANGINTERNALERROR, "unamedModuleForSystemLoader was not initialized");
1546-
} else if (NULL != unamedModuleForSystemLoader->moduleObject) {
1547-
vmFuncs->setCurrentExceptionUTF(currentThread, J9VMCONSTANTPOOL_JAVALANGINTERNALERROR, "module is already set in the unamedModuleForSystemLoader");
1544+
if (NULL == unnamedModuleForSystemLoader) {
1545+
vmFuncs->setCurrentExceptionUTF(currentThread, J9VMCONSTANTPOOL_JAVALANGINTERNALERROR, "unnamedModuleForSystemLoader was not initialized");
1546+
} else if (NULL != unnamedModuleForSystemLoader->moduleObject) {
1547+
vmFuncs->setCurrentExceptionUTF(currentThread, J9VMCONSTANTPOOL_JAVALANGINTERNALERROR, "module is already set in the unnamedModuleForSystemLoader");
15481548
} else {
15491549
J9Module *j9mod = createModule(currentThread, modObj, systemClassLoader, NULL /* NULL name field */);
1550-
unamedModuleForSystemLoader->moduleObject = modObj;
1551-
Trc_MODULE_setUnamedModuleForSystemLoaderModuleObject(currentThread, j9mod, unamedModuleForSystemLoader);
1550+
unnamedModuleForSystemLoader->moduleObject = modObj;
1551+
Trc_MODULE_setUnnamedModuleForSystemLoaderModuleObject(currentThread, j9mod, unnamedModuleForSystemLoader);
15521552
}
15531553
#else /* JAVA_SPEC_VERSION >= 21 */
15541554
if (NULL == J9VMJAVALANGCLASSLOADER_UNNAMEDMODULE(currentThread, systemClassLoader->classLoaderObject)) {

runtime/oti/j9.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ static const struct { \
287287
#define internalExitVMToJNI internalReleaseVMAccess
288288
#endif /* !J9VM_INTERP_ATOMIC_FREE_JNI */
289289

290-
#define J9_IS_J9MODULE_UNNAMED(vm, module) ((NULL == module) || (module == vm->unamedModuleForSystemLoader))
290+
#define J9_IS_J9MODULE_UNNAMED(vm, module) ((NULL == module) || (module == vm->unnamedModuleForSystemLoader))
291291

292292
#define J9_IS_J9MODULE_OPEN(module) (TRUE == module->isOpen)
293293

0 commit comments

Comments
 (0)