-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider to provide an in-application view for notification/sponsorship #134
Comments
Hi @merks , thank you for proposing this! This was probably already discussed but I'll nevertheless ask the obvious question: wouldn't it suffice to let the "official" sponsor page adapt to the current theme? The internal browser works with that too (at least for Windows) |
First the basic background. Sponsoring is down by 50% over the last year and a bit. This has an impact on the IDE WG budget. What can we do the improve this? We are told that the webdev folks are working on design improvements. Of course there other questions too such as why is it down? Also it would be nice to gather statistics so that when we try something different we can see what difference it makes... In any case, Wayne did a quick prototype of a view some time back and there was some discussion about that here: waynebeaton/org.eclipse.sponsor#1 As stated in that issue:
That work was presented to the IDE WG and discussed with the Planning Council. So I'm trying to get something done to keep the issue moving forward because this has been stalled for a very long time. I'm not personally confident that showing information in a view will make a significant difference, but it is "something else". That being said, I do not like to waste my efforts on pointless activities... As I see it, there are multiple angles to this:
The following is the status quo:
Some technical considerations.
Finally to your question:
Take a small step back and ask yourself whether sponsorship is down because one or more of the following reasons?
We don't have answers to any of those and basically are stalled on "try to do something else". You'll note that there is little in the way of comments here which one can interpret in different ways:
|
Thank you @merks for the detailed explanation. I see that I've missed several nuances with my very naive proposal (thank God I'm not designing UI/UX 😅 ). You're right: even if the webpage adapts its color to the current theme, the internal browser is smaller and the content in the page is designed/aligned to bigger windows so the result in the IDE would be subpar. One small detail though: the initial situation changed regarding the I'll keep the general discussion in waynebeaton/org.eclipse.sponsor#1 to avoid digressing here in your PR. Thank you for the pointer! |
Yes, the IE thing was also a problem because it wasn't actually possible to complete the donation steps within the embedded crappy old IE browser. I'm not 100% sure it's possible with Edge but it seems to I could get close to the final steps of donation when testing it earlier in the week. I'm very happy with Edge because it supports modern javascript so much better! I don't think discussing other alternatives here is a digression of the general purpose and theme of the changes this issue is looking to make. 😁 |
- Support filtered requirements resolved against the installation profile to control whether the notification is applicable. - Support eclipse+setup scheme to open a setup configuration and apply it to the installation/workspace. - Support eclipse+external scheme to open an external browser. - Add the color and background-color as determined by the IDE's theme as query parameters to the URL. #134
- Improve support for SelfHostingProfile for easier testing of eclipse+setup links with p2 tasks. - Augment the query parameters passed to the notification URI with details about the running IDE including the java.version. - Support setting system properties while performing setup tasks. - Support the system property oomph.setup.p2.skip being set dynamically to disable p2 tasks. - Provide support for remembering the notification URI so that the notification page can support permanently dismissing the notification and allow this to be specific globally, per-installation, and per-workspace. - Automatically hide the Welcome view part if present. - Allow the configuration to specify the trigger and the whether the updater remains visible. #134
For quite some time, Oomph contributes the following menu item:
It opens a URL as specified in the Oomph catalog index so we can dynamically control and URL and the content:
oomph/setups/org.eclipse.setup
Lines 7 to 13 in 7fe7012
It opens in a browser or in an editor depending on this user preference which defaults to external:
There have been discussions about providing a similar type of notification via an in-application view.
I've prototyped something rough. Here we see the regular sponsorship link opened in an editor in the light-theme IDE along with the new view at the bottom showing how the content can be dynamically adjusted to suit the theme:
E.g., here is how it looks in dark theme:
Note how the foreground and background colors match the theme. This is accomplished by passing query parameters that can be used by the javascript of the page to adjust the appearance of the content which we can see here in an actual external browser.
You can contrast this with the editor showing the standard sponsorship page which is really not well-designed to be shown within a themed IDE application.
It's not 100% clear what additional value this will bring nor how best to exploit this perhaps both for potential notification, e.g., of some security problem, and for prompting interest in sponsorship. How often should we show it? Every startup? Once a week on startup? How will this be better than the current/old approach?
The text was updated successfully, but these errors were encountered: