Incorrect hiderefs Behavior

[joelthompson]

Version

master

Operating System

Linux/Unix

Bug description

According to the Git documentation, there are three ways hideRefs can be set:

1. transfer.hideRefs: This hides the refs from both receive-pack and upload-pack commands
2. uploadpack.hideRefs: This hides the ref from only upload-pack but leaves it visible for receive-pack commands
3. receive.hideRefs: The opposite of the above: hide the ref only from receive-pack commands but leave it visible for upload-pack commands.

JGit only looks at uploadpack.hiderefs and ignores transfer.hiderefs and receive.hiderefs

jgit/org.eclipse.jgit/src/org/eclipse/jgit/transport/TransferConfig.java

Line 213 in a903ab5

hideRefs = rc.getStringList("uploadpack", null, "hiderefs");

Further, when uploadpack.hiderefs is set; JGit acts as if transfer.hiderefs had been set instead and hides the listed refs from both receive-pack and upload-pack.

The net result of this is there's no way to use hideRefs to hide a ref from only upload-pack or receive-pack.

Actual behavior

transfer.hiderefs and receive.hiderefs are both ignored; uploadpack.hiderefs acts the way transfer.hiderefs should.

Expected behavior

transfer.hiderefs, receive.hiderefs, and uploadpack.hiderefs to behave as describe in the Git documentation.

Relevant log output

No response

Other information

Not sure it's material, but the Git docs specify hideRefs with a capital R while JGit looks at hiderefs with a lower-case r

[msohn]

git config keys are case insensitive