a ClassCastException is thrown when EL is used in conjunction with a custom PageContext wrapper

[glassfishrobot]

The following method in org.apache.jasper.runtime.PageContextImpl

private static ExpressionFactory getExpressionFactory(
            PageContext pageContext) {

        PageContextImpl pc =
            (PageContextImpl) JspContextWrapper.getRootPageContext(pageContext);
        return pc.getJspApplicationContext().getExpressionFactory();
    }

results in the exception.

However, it's possible to accomplish the exact same thing in a compliant way, without a cast, using:

JspApplicationContext jspApplicationContext =
            JspFactory.getDefaultFactory().getJspApplicationContext(
pageContext.getServletContext());

        return jspApplicationContext.getExpressionFactory();

Environment

any

Affected Versions

[current]

[glassfishrobot]

@glassfishrobot Commented
Reported by rotty

[glassfishrobot]

@glassfishrobot Commented
Was assigned to super_glassfish

[glassfishrobot]

@glassfishrobot Commented
rotty said:
I would attach a patch file.. but I can't seem to attach files any more:

commit dde29b0287e90efa8ff4eb27b332f4b54b88dd12
Author: Raymond Auge <[email protected]>
Date:   Fri Mar 4 11:42:17 2016 -0500

    Get ExpressionFactory without cast

    Signed-off-by: Raymond Auge <[email protected]>

diff --git a/impl/src/main/java/org/apache/jasper/runtime/PageContextImpl.java b/impl/src/main/java/org/apache/jasper/runtime/PageContextImpl.java
index 3365f42..a7a17e7 100644
--- a/impl/src/main/java/org/apache/jasper/runtime/PageContextImpl.java
+++ b/impl/src/main/java/org/apache/jasper/runtime/PageContextImpl.java
@@ -958,9 +958,11 @@ public class PageContextImpl extends PageContext {
     private static ExpressionFactory getExpressionFactory(
             PageContext pageContext) {

-        PageContextImpl pc =
-            (PageContextImpl) JspContextWrapper.getRootPageContext(pageContext);
-        return pc.getJspApplicationContext().getExpressionFactory();
+        JspApplicationContext jspApplicationContext =
+            JspFactory.getDefaultFactory().getJspApplicationContext(
+pageContext.getServletContext());
+
+        return jspApplicationContext.getExpressionFactory();
     }

     /**

[glassfishrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JSP-49

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/javaee-jsp-api/issues/49
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot