Excessive memory use & GC caused by use of exception for control flow

[glassfishrobot]

Construction or initialization of a JspWriterImpl results in an attempt to set the buffer size the result of which may be an IllegalStateException.

This can be reduced by simply checking to see if the response is committed instead, and avoid the exception as control flow.

Environment

any

Affected Versions

[current]

[glassfishrobot]

@glassfishrobot Commented
Reported by rotty

[glassfishrobot]

@glassfishrobot Commented
Was assigned to super_glassfish

[glassfishrobot]

@glassfishrobot Commented
rotty said:
patch

======================================
diff --git a/org/apache/jasper/runtime/JspWriterImpl.java b/org/apache/jasper/runtime/JspWriterImpl.java
index ead4f5e..9d09f67 100644
— a/org/apache/jasper/runtime/JspWriterImpl.java
+++ b/org/apache/jasper/runtime/JspWriterImpl.java
@@ -139,13 +139,16 @@ public class JspWriterImpl extends JspWriter {
throw new IllegalArgumentException("Buffer size <= 0");
this.response = response;
allocateCharBuffer();

• // START OF IASRI 4641975/6172992

• try { - response.setBufferSize(sz); - } catch (IllegalStateException ise) { - // ignore - }

  • // END OF IASRI 4641975/6172992
  • if (!response.isCommitted()) {
  • // START OF IASRI 4641975/6172992
  • try { + response.setBufferSize(sz); + } catch (IllegalStateException ise) { + // ignore + }
  • // END OF IASRI 4641975/6172992
  • }
    }

  void init( ServletResponse response, int sz, boolean autoFlush ) {
  @@ -153,13 +156,16 @@ public class JspWriterImpl extends JspWriter {
  this.autoFlush=autoFlush;
  this.bufferSize=sz;
  allocateCharBuffer();

  • // START OF IASRI 4641975/6172992
  • try { - response.setBufferSize(sz); - }

  catch (IllegalStateException ise)

  { - // ignore - }

• // END OF IASRI 4641975/6172992
  +

  • if (!response.isCommitted())Unknown macro: {+ // START OF IASRI 4641975/6172992+ try { + response.setBufferSize(sz); + } catch (IllegalStateException ise) { + // ignore + }+ // END OF IASRI 4641975/6172992+ }

  }

/** Package-level access

[glassfishrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JSP-51

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/javaee-jsp-api/issues/51
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot