org/glassfish/web/javax.servlet.jsp 2.3.2 jar does not contain JDTJavaCompiler

[glassfishrobot]

The Jetty project uses the reference jsp impl in OSGi for which it is necessary to use a non jsr199 compiler (see previous issue https://java.net/jira/browse/JSP-21 for an explanation).

The latest 2.3.2 jar is missing the JDTJavaCompiler class, and thus its not possible to use the reference impl inside OSGi.

Could the JDTJavaCompiler class be reinstated into the org/glassfish/web/javax.servlet.jsp jar please?

Alternatively, issue https://java.net/jira/browse/JSP-29 asks for an extensible mechanism for specifying the compiler class to use, which may be a good idea.

thanks
Jan

Affected Versions

[current]

[glassfishrobot]

@glassfishrobot Commented
Reported by janbartel

[glassfishrobot]

@glassfishrobot Commented
eirbjor said:
+1 for re-adding JDTJavaCompiler and AntCompiler.

What was the reason for excluding them from compilation? Was it related to dependencies being pulled in transitively?

If so, could we just mark them as optional in Maven? Then they will be on the compilation class path, but not on the runtime class path.

I'm not allowed to upload attachments, so here is a patch inline:

Index: pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- pom.xml	(revision 1462)
+++ pom.xml	(revision )
@@ -138,16 +138,6 @@
     <compilerArgument>-Xlint:unchecked</compilerArgument>
     <excludes>
         <exclude>
-            org/apache/jasper/compiler/JDTJavaCompiler.java
-        </exclude>
-        <exclude>
-            org/apache/jasper/compiler/AntJavaCompiler.java
-        </exclude>
-        <exclude>
-            <!-- This is only used by AntJavaCompiler -->
-            org/apache/jasper/util/SystemLogHandler.java
-        </exclude>
-        <exclude>
             <!-- We keep the source just in case -->
             org/apache/jasper/runtime/PerThreadTagHandlerPool.java
         </exclude>
@@ -296,17 +286,22 @@
         <dependency>
             <groupId>javax.servlet.jsp</groupId>
             <artifactId>javax.servlet.jsp-api</artifactId>
-            <version>2.3.2-b01-SNAPSHOT</version>
+            <version>2.3.1</version>
         </dependency>

-<!--
-  Needed only if we include JDTJavaCompiler.java
     <dependency>
       <groupId>eclipse</groupId>
       <artifactId>jdtcore</artifactId>
       <version>3.1.0</version>
-      <scope>compile</scope>
+      <optional>true</optional>
     </dependency>
--->
+
+    <dependency>
+        <groupId>ant</groupId>
+        <artifactId>ant</artifactId>
+        <version>1.6.5</version>
+        <optional>true</optional>
+    </dependency>
+
     </dependencies>
 </project>

[glassfishrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JSP-38

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/javaee-jsp-api/issues/38
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot