Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on local encoding #1106

Open
dmatej opened this issue Sep 13, 2024 · 0 comments
Open

Dependency on local encoding #1106

dmatej opened this issue Sep 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dmatej
Copy link
Contributor

dmatej commented Sep 13, 2024

The generated file charset is not set explicitly, so the file is encoded by user's charset. It should be set explicitly - I recommend UTF-8, it should be enough.

https://github.com/eclipse-ee4j/glassfish-hk2/blob/master/maven-plugins/hk2-inhabitant-generator/src/main/java/org/jvnet/hk2/generator/internal/GeneratorRunner.java#L346

We should check if there isn't more such issues.

@dmatej dmatej added the bug Something isn't working label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant