Clean up/complete tests

[glassfishrobot]

Integrate Arquillian/GlassFish Embedded/Weld EE/Weld SE as needed.

[glassfishrobot]

@glassfishrobot Commented
Reported by reza_rahman

[glassfishrobot]

@glassfishrobot Commented
Was assigned to reza_rahman

[glassfishrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA CARGOTRACKER-6

[glassfishrobot]

• Issue Imported From: Clean up/complete unit tests javaee/cargotracker#6
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot

[thadumi]

@m-reza-rahman this can be close. After I'll do some test with the embedded we can discuss again about adding it or not

[m-reza-rahman]

To be honest, our tests are very inadequate for a reference project. We definitely need to improve that. However, this can be done after the Jakarta EE 9 release.

Reza Rahman
Jakarta EE Ambassador, Author, Blogger, Speaker

Please note views expressed here are my own as an individual community member and do not reflect the views of my employer.

[m-reza-rahman]

Looks like Arquillian now supports JUnit 5. We should upgrade when we can.

Reza Rahman
Jakarta EE Ambassador, Author, Blogger, Speaker

Please note views expressed here are my own as an individual community member and do not reflect the views of my employer.

[yashTEF]

@m-reza-rahman and @glassfishrobot, What are the deliverables for this, would we need to adopt junit 5 style in integration tests and adding JMeter tests for stress testing etc.

I can take this up but would need some help.

[m-reza-rahman]

We cannot upgrade to JUnit 5 until the Jakarta EE 10 update is done. There is a separate issue for that. Similarly, there is a separate issue for JMeter. There are two aspects of the work on this issue:

• Looking at the current tests to clean them up.
• Evaluate whether we have an adequate amount of tests. If we don’t, add more tests.

Note that while I can offer some help, this is not a simple task by any stretch of the imagination. It requires a very self motivated individual with a relatively high proficiency level. I would say in academic terms, this is for someone that routinely gets A+’s on their 200/300 level CS courses. There is simpler work to pick up.

[karianna]

Looks like JUnit 5 support is in, can this be closed or is it more a case of adding more tests for functional gaps? I can try to run the jacoco coverage tests if that would help

[m-reza-rahman]

There are huge gaps. I would say our coverage is maybe 5-10%. Someone needs to analyze carefully and chart out how we sensibly improve test coverage.

[karianna]

Jacoco coverage stats as of tip today.

[m-reza-rahman]

~25% is a lot higher than what I thought. As I said though, we really can't rely on these tests for stability/regression. It'll probably be a very long time before we can. This is an area where longer term contribution from at least one dedicated person would really help.