Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-plugin: Does not handle multi-module projects where the top-level project is just a reactor #371

Open
bjhargrave opened this issue Sep 6, 2024 · 0 comments

Comments

@bjhargrave
Copy link

This code in the mojo:

// We are aggregating the deps for all projects in the reactor, so we only need
// to execute once. This check ensures we run only during the build of the
// top-level reactor project and avoids duplicate invocations
if (!mavenSession.getCurrentProject().equals(mavenSession.getTopLevelProject())) {
return;
}

just returns without doing anything when the project is not the top-level project. But if the top-level project is just a reactor and not a parent to the other modules in the build, then there is no output from the license-tool.

See the Eclipse Transformer project for an example. After adding the license-tool to the build (bjhargrave/transformer@c3e061b), the build shows no results for the license-check goal.

https://github.com/bjhargrave/transformer/actions/runs/10727766241/job/29750817183#step:6:1584

[INFO] --- license-tool:1.1.0:license-check (license-check) @ org.eclipse.transformer ---
[INFO] 
[INFO] --- install:3.1.3:install (default-install) @ org.eclipse.transformer ---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant