Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on call-mvn-license-check github workflow #344

Open
zulus opened this issue May 23, 2024 · 4 comments
Open

False positive on call-mvn-license-check github workflow #344

zulus opened this issue May 23, 2024 · 4 comments

Comments

@zulus
Copy link

zulus commented May 23, 2024

Previously i reported in wrong place: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4353

Dash keeps complaining about PDT licenses, but no new libs has been added since a long time: https://github.com/eclipse-pdt/pdt/actions/runs/8052772404

In default actions result I see Plugin validations issues detected * org.apache.maven.plugins:maven-site-plugin:3.12.1 but this plugin is automatically added by maven (visible via help:effective-pom), I checked for example wildwebdeveloper project (help:effective-pom also reports this plugin but no problems in license check)

I tried empty pull request with "/request-license-review" but without luck : eclipse-pdt/pdt#269 and https://github.com/eclipse-pdt/pdt/actions/runs/9210361818 (vetting review-summary is empty)

@waynebeaton
Copy link
Collaborator

The summary files are dated February 2024.

AFAICT, the build is failing while trying to resolve a dependency.

https://github.com/eclipse-pdt/pdt/actions/runs/9210361818/job/25337188139#step:11:51

@zulus
Copy link
Author

zulus commented May 24, 2024

@zulus
Copy link
Author

zulus commented May 25, 2024

Now complain about old eclipse project (org.eclipse.ptp.rdt.sync) : https://github.com/eclipse-pdt/pdt/actions/runs/9236342263/job/25412087069 (RDT sync)

@waynebeaton
Copy link
Collaborator

Correct url with recent error: https://github.com/eclipse-pdt/pdt/actions/runs/8052422043/job/21992505636

The date is Feb 26.

image

When we retired the Eclipse PTP project, the ability to automatically associating its contents with the project broke. I've added some hints; it should scan clean now.

org.apache.maven.plugins:maven-site-plugin:3.12

AFAICT, this is unrelated to the Eclipse Dash License Tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants