Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets - Methods are placed at wrong position in the menu #408

Closed
eselmeister opened this issue Aug 27, 2020 · 7 comments
Closed

Assets - Methods are placed at wrong position in the menu #408

eselmeister opened this issue Aug 27, 2020 · 7 comments

Comments

@eselmeister
Copy link
Contributor

After modifying the assets (add/delete), additional methods are displayed at the wrong position. They should be placed under "User Methods":

Bildschirmfoto von 2020-08-27 12-47-00

Bildschirmfoto von 2020-08-27 12-48-33

@laeubi Please add process method assets at the correct position.

@laeubi
Copy link
Contributor

laeubi commented Aug 27, 2020

The method Will be placed in the category Named in the User-Method when installed via the Assetsmanager,, User-Methods only list those in the standard location. So if you need it to be placed under User-Methods anyways, simply use "User Methods" as category name.

@eselmeister
Copy link
Contributor Author

@laeubi OK, I tried to test it. But even after removing the "Process Method" from the Assets, it's not removed from the menu. It's even not removed after closing and opening the editor.

Bildschirmfoto von 2020-08-27 13-29-45

Bildschirmfoto von 2020-08-27 13-29-49

Bildschirmfoto von 2020-08-27 13-30-11

laeubi pushed a commit that referenced this issue Aug 27, 2020
@laeubi
Copy link
Contributor

laeubi commented Aug 27, 2020

I submitted a patch, please retry with that change.

@eselmeister
Copy link
Contributor Author

@laeubi OK, the *.bak files are not recognized as normal methods any longer. But

  • adding a "Process Method" via the Assets requires a restart of the application
  • removing a "Process Method" via the Assets requires a restart of the application (it's still in the menu after removing it)

So is the same for "User Methods", e.g. if one modifies the methods via the method editor toolbar.

@laeubi
Copy link
Contributor

laeubi commented Aug 27, 2020

If I remmber right to get rid of "flickering" / "event-storm" currently the menu is not instantly updated but only when you close/reopen the editor.

@eselmeister
Copy link
Contributor Author

@laeubi That's why I was wondering, why you have closed the JFace menu issue yesterday?
eclipse/swtchart#84

@laeubi
Copy link
Contributor

laeubi commented Sep 1, 2020

The issue itself "Methods are placed at wrong position in the menu" is resolved as it works like intended, if anything unclear let me know.

Whether or not and how I'm contribution to swtchart is defiantly out of scope here.

@laeubi laeubi closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants