Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Trailing Whitespace on Save #5297

Open
davidwindell opened this issue Jun 8, 2017 · 8 comments
Open

Remove Trailing Whitespace on Save #5297

davidwindell opened this issue Jun 8, 2017 · 8 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@davidwindell
Copy link
Contributor

In common with most popular IDEs, it would be great to have an option to have whitespace automatically removed on save.

This is a feature request.
@benoitf benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 8, 2017
@davidwindell
Copy link
Contributor Author

It would be great if this could be implemented soon, it's one of the main things our team complain about because we have cs-checks that don't like the whitespace.

@gorkem
Copy link
Contributor

gorkem commented Aug 23, 2019

Is this also valid for Che 7 IDE?

@davidwindell
Copy link
Contributor Author

If Theia doesn't have it then I'd say yes please. I'm still struggling with getting Che running with Rancher so can't confirm yet.

@davidwindell
Copy link
Contributor Author

@gorkem it looks like theia has an option trimAutoWhitespace but it doesn't seem possible to apply in Che https://github.com/eclipse-theia/theia/blob/57be198635ced9325aaad0ada885b60e02154128/packages/editor/src/browser/editor-preferences.ts#L925

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2020
@davidwindell
Copy link
Contributor Author

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2020
@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2020
@davidwindell
Copy link
Contributor Author

I suppose this is one for Theia, so might as well allow it to go stale.

@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gorkem @benoitf @davidwindell @ericwill @che-bot