fix: delete workspace flow #1318
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1318 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1318", name: che-dashboard}]}}]" |
...ard-frontend/src/store/Workspaces/devWorkspaces/actions/actionCreators/terminateWorkspace.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1318 +/- ##
==========================================
- Coverage 91.81% 91.52% -0.30%
==========================================
Files 501 501
Lines 45535 45558 +23
Branches 3183 3167 -16
==========================================
- Hits 41808 41695 -113
- Misses 3695 3836 +141
+ Partials 32 27 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Changing storage type before removing workspace is not a good option since PVC will not be deleted / cleaned after that.
Given that this is a regression we need to:
- detect the commit that resulted in this behaviour
- review the changes and identify if there is another option to fix the problem
@dmytro-ndp @artaleks9 folks, maybe you have more details on which upstream version the problem started to happen
Also, marking eclipse-che/che#23337 as a blocker
Signed-off-by: Oleksii Orel <[email protected]>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1318 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1318", name: che-dashboard}]}}]" |
Signed-off-by: Oleksii Orel <[email protected]>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1318 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1318", name: che-dashboard}]}}]" |
What does this PR do?
Fix delete workspace flow.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fix eclipse-che/che#23337
Is it tested? How?
Release Notes
Docs PR