Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift connector and Che: not possible to have 2 components connected to 2 projects in the same workspace #15273

Open
sunix opened this issue Nov 21, 2019 · 10 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Nov 21, 2019

Describe the bug

With the openshift connector, trying to create 2 components linked to 2 projects in the same workspace. Openshift connector is trying to open a new workspace (window) for each component. but somehow, Che is not handling that situation well: some views are broken and the user may want to stay in a single window.

@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 21, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 21, 2019
@tsmaeder
Copy link
Contributor

Upstream issue?

@tsmaeder tsmaeder added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Nov 22, 2019
@sunix
Copy link
Contributor Author

sunix commented Nov 22, 2019

@tsmaeder this is a high level user issue, the assignee who would take it would analyse a create upstream issue if needed.

@azatsarynnyy
Copy link
Member

@sunix could you please describe in detail what are the steps to reproduce the described bug.

I've been able to successfully create two components linked to two different projects.
See it in my last demo https://www.youtube.com/watch?v=kjVBLqTNvRA

@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che team/ide labels Nov 27, 2019
@benoitf benoitf added this to the Backlog - IDE 1 milestone Nov 27, 2019
@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 27, 2019
@sunix
Copy link
Contributor Author

sunix commented Nov 27, 2019

@azatsarynnyy it is because your are using a binary file for the backend. it fails with 2 components using both source folders in the same workspace.
I am making more tests at the moment to provide more information but the problem may come by the fact that the vscode openshift connector works well with workspace root for each component

@sunix
Copy link
Contributor Author

sunix commented Nov 27, 2019

@azatsarynnyy to me this is the right way to fix this issue: #15347
I have tried to manually add workspace roots for each components and it works well.

@vparfonov vparfonov removed this from the Backlog - IDE 1 milestone Nov 28, 2019
@azatsarynnyy
Copy link
Member

@sunix I see. Thank you for the explanation!

@sunix sunix removed the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Dec 3, 2019
@sunix
Copy link
Contributor Author

sunix commented Dec 3, 2019

@azatsarynnyy having that said, I think we should have a better way to manage workspace roots in general: when a plugin/vscode ext is trying to open a new workspace of a specific folder, we should add a workspace root instead in the current workspace. WDYT ?

@azatsarynnyy
Copy link
Member

I like the solution proposed in #15347

@azatsarynnyy
Copy link
Member

relabeled to area/plugins as it's related to OpenShift Connector plugin

@azatsarynnyy azatsarynnyy added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che labels Feb 6, 2020
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 21, 2020
@ericwill ericwill added this to the Backlog - Plugins milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

7 participants