Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include source map into theia image by default #13729

Open
vzhukovs opened this issue Apr 16, 2019 · 7 comments
Open

Include source map into theia image by default #13729

vzhukovs opened this issue Apr 16, 2019 · 7 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/technical-debt Technical debt issue lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.

Comments

@vzhukovs
Copy link
Contributor

Description

There is a need to debug a client side (theia in workspace, not a dedicate hosted instance) in theia, but when image is build, all files needed for developmen are removed due to production cleaning step. This blocks debugging client side and instigates editing theia image and implies an extra work to build image, push it into own registry and edit deployment configuration in minikube cluster that might resets after cluster stops.

@evidolob
Copy link
Contributor

I think there are some specific reasons why we remove source maps from che-theia image, @benoitf what do you think?

@benoitf
Copy link
Contributor

benoitf commented Apr 16, 2019

well, first I do not think it's kind of a blocker.

second, yes it's to have a minimal image size.
When I discussed that with @davidfestal we were thinking to store sourcemaps into the CDN as well so it would not be stored inside the image but could be available through CDN

@vzhukovs
Copy link
Contributor Author

It blocks me at the moment, because I'm trying to remove the code, which removes sourcemaps from image and can't get success with it at the moment. It would be good to have the environment variable which will include sourcemaps during theia image build (to include sourcemaps and cdn support or not), enabled by default.

@benoitf
Copy link
Contributor

benoitf commented Apr 16, 2019

IMHO you're blocked is different that there is blocker in product.

@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. team/ide2 labels Jul 5, 2019
@davidfestal davidfestal added the kind/technical-debt Technical debt issue label Nov 6, 2019
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot closed this as completed May 20, 2020
@vzhukovs vzhukovs reopened this May 20, 2020
@vzhukovs vzhukovs removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 20, 2020
@tsmaeder
Copy link
Contributor

+1

@che-bot
Copy link
Contributor

che-bot commented Jan 20, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2021
@tsmaeder tsmaeder added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/technical-debt Technical debt issue lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

7 participants