Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin broker should be able to send warning about plugins configuration to WS master #13020

Open
garagatyi opened this issue Mar 29, 2019 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@garagatyi
Copy link

Description

Plugin registry notation changes will introduce field deprecated into meta.yaml:

publisher: plugin_publisher
id: plugin_id
version: 1.2.3
name: Some plugin
deprecate:
   autoMigrate: true
   migrateTo: another_publisher/another_plugin_id:1.0.0

See explanation here eclipse-che/che-plugin-registry#55 (comment)

Plugin broker should send a warning when plugin with deprecated section is being processed to WS master.
WS master than should add it to the workspace runtime warnings.
And UD will be able to show it to the user.
Apart from that, broker should send brokering log about that, so user would be able to see it when workspace is starting.

Implementation details:
At the moment broker sends JSON list to WS master with Che plugins descriptions.

  1. We need to change that to an object that contains field warnings. And add above described warning to this field.
  2. WS master should add to workspace runtime warnings that come from plugin broker.
@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2019
@amisevsk
Copy link
Contributor

I believe this will be resolved in a different way in eclipse-che/che-plugin-registry#228

Leaving open as we should decide if this is sufficient of if the broker should do additional work

@amisevsk
Copy link
Contributor

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2019
@che-bot
Copy link
Contributor

che-bot commented Mar 25, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 25, 2020
@amisevsk
Copy link
Contributor

/remove-lifecycle stale

@amisevsk amisevsk added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Mar 25, 2020
@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants