Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Reorg the repository into plugins/, features/, releng/ and other directories #170

Closed
cxbrooks opened this issue Sep 24, 2016 · 5 comments
Closed
Assignees

Comments

@cxbrooks
Copy link
Contributor

cxbrooks commented Sep 24, 2016

The top level directory of the repo is cluttered. Perhaps we should create plugins/, features/, releng/ and other directories.

We would need to update the how Maven builds.

This should happen after the Science 2016 Release.

@cxbrooks cxbrooks added this to the Spring2017Release milestone Sep 24, 2016
@erwindl0
Copy link
Contributor

@cxbrooks cxbrooks self-assigned this Mar 27, 2017
@erwindl0 erwindl0 assigned erwindl0 and unassigned cxbrooks Jun 25, 2017
erwindl0 added a commit that referenced this issue Jun 26, 2017
Signed-off-by: Erwin De Ley <[email protected]>
erwindl0 added a commit that referenced this issue Jun 26, 2017
erwindl0 added a commit that referenced this issue Jun 26, 2017
Signed-off-by: Erwin De Ley <[email protected]>
@erwindl0
Copy link
Contributor

subfolders created according to some examples I found.
the build works again.

can you review and close if OK?

@erwindl0 erwindl0 modified the milestones: OxygenRelease, Spring2017Release Jun 26, 2017
@cxbrooks
Copy link
Contributor Author

Thanks for doing this! It looks pretty good. I was able to check out a new tree and run mvn.

A couple of comments:

  1. I think we lost the Welcome Window, see Bug Create Welcome Support #169 Create Welcome Window Support

  2. After checking out a new tree and doing the setup by hand, in the Package Explorer, the various packages are displayed at the top level instead of in their folders:

screen shot 2017-06-26 at 2 15 14 pm

However, the top level directory looks fine:

bash-3.2$ ls ~/git/triquetrum
CONTRIBUTING.md         README.md               javadoc                 releng                  tests
LICENSE                 examples                plugins                 setups
README-python-rpc.md    features                pom.xml                 target
bash-3.2$

Any ideas?

@erwindl0
Copy link
Contributor

erwindl0 commented Jun 27, 2017 via email

@cxbrooks
Copy link
Contributor Author

I'll reopen the Welcome Window bug.

Thanks for the info about the subfolders.

Let's close this.

cxbrooks pushed a commit that referenced this issue Sep 26, 2017
Signed-off-by: Erwin De Ley <[email protected]>
cxbrooks pushed a commit that referenced this issue Sep 26, 2017
cxbrooks pushed a commit that referenced this issue Sep 26, 2017
Signed-off-by: Erwin De Ley <[email protected]>
@erwindl0 erwindl0 modified the milestones: OxygenRelease, Science2017Release Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants