-
Notifications
You must be signed in to change notification settings - Fork 14
Reorg the repository into plugins/, features/, releng/ and other directories #170
Comments
some inspiration can be found e.g. on http://www.vogella.com/tutorials/EclipseTycho/article.html#good-practice-for-eclipse-components-organization |
Signed-off-by: Erwin De Ley <[email protected]>
Signed-off-by: Erwin De Ley <[email protected]>
subfolders created according to some examples I found. can you review and close if OK? |
Thanks for doing this! It looks pretty good. I was able to check out a new tree and run mvn. A couple of comments:
However, the top level directory looks fine:
Any ideas? |
Christopher,
The welcome screen hasn’t worked yet for me, i.e. also not before the folder restructuring.
We need to check that topic separately I think.
The Eclipse Project explorer indeed does not show projects in subfolders, as far as I know.
We might define so-called “working sets” that correspond to folders, if you prefer.
(I think the Eclipse WTP project has hierarchical project views, but that’s for doing Java Enterprise dvp, not RCP)
Regards
erwin
From: Christopher Brooks [mailto:[email protected]]
Sent: Monday, June 26, 2017 11:18 PM
To: eclipse/triquetrum <[email protected]>
Cc: erwin de ley <[email protected]>; Assign <[email protected]>
Subject: Re: [eclipse/triquetrum] Reorg the repository into plugins/, features/, releng/ and other directories (#170)
Thanks for doing this! It looks pretty good. I was able to check out a new tree and run mvn.
A couple of comments:
1. I think we lost the Welcome Window, see Bug #169 <#169> Create Welcome Window Support
2. After checking out a new tree and doing the setup by hand, in the Package Explorer, the various packages are displayed at the top level instead of in their folders:
<https://user-images.githubusercontent.com/861991/27560695-015a7990-5a7a-11e7-99b5-af9cf60e6a6a.png>
However, the top level directory looks fine:
bash-3.2$ ls ~/git/triquetrum
CONTRIBUTING.md README.md javadoc releng tests
LICENSE examples plugins setups
README-python-rpc.md features pom.xml target
bash-3.2$
Any ideas?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub <#170 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AGKZ4U9ykf0oZTrrpIZOx-rf88azuSJRks5sIB_4gaJpZM4KFi5L> . <https://github.com/notifications/beacon/AGKZ4bwW4QF1XOV0zOnQQoSarqNgjyAXks5sIB_4gaJpZM4KFi5L.gif>
|
I'll reopen the Welcome Window bug. Thanks for the info about the subfolders. Let's close this. |
Signed-off-by: Erwin De Ley <[email protected]>
Signed-off-by: Erwin De Ley <[email protected]>
The top level directory of the repo is cluttered. Perhaps we should create plugins/, features/, releng/ and other directories.
We would need to update the how Maven builds.
This should happen after the Science 2016 Release.
The text was updated successfully, but these errors were encountered: