Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Need a way for OSGi bundles to add to the MoML Filters #113

Closed
cxbrooks opened this issue Aug 29, 2016 · 3 comments
Closed

Need a way for OSGi bundles to add to the MoML Filters #113

cxbrooks opened this issue Aug 29, 2016 · 3 comments
Assignees

Comments

@cxbrooks
Copy link
Contributor

A Java package can appear at most in one loaded OSGi bundle in an application.

We have a number of Ptolemy II OSGi bundles that have completed the Contribution Questionnaire process for third party libraries (see https://wiki.eclipse.org/Development_Resources/Contribution_Questionnaire#Third_Party_Libraries and Bug #70: Ipzilla issues for Triquetrum third party code)

If someone wants to add a Ptolemy actor that is in one of the packages in one of the bundles that have passed review, then either the bundle needs to be re-reviewed or the actor needs to be renamed.

In general, we don't want to request frequent reviews.

So, we should augment the system so that a bundle can register a MoMLFilter that will cause the MoMLParser to read in a model file that refers to the actor with the old ptII package name and instead look up the new Triquetrum package name.

See also https://wiki.eclipse.org/Triquetrum/Ptolemy/Porting

@erwindl0
Copy link
Contributor

erwindl0 commented Oct 5, 2016

I wrote a short text about how to address this situation on our wiki .

Is that sufficient for this issue?

@cxbrooks
Copy link
Contributor Author

cxbrooks commented Oct 5, 2016

To close this, I want to try out the process.

@cxbrooks
Copy link
Contributor Author

cxbrooks commented Oct 5, 2016

My previous comment was on the wrong bug.

We can close this bug because we have Bug #90 Document the process of adding an actor.

@cxbrooks cxbrooks closed this as completed Oct 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants