Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

AttributionDocumentGenerator cannot handle layouting unicodes #548

Open
2 tasks
bs-ondem opened this issue Jun 30, 2020 · 1 comment
Open
2 tasks

AttributionDocumentGenerator cannot handle layouting unicodes #548

bs-ondem opened this issue Jun 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@bs-ondem
Copy link
Contributor

Summary of the Bug

The AttibutionDocumentGenerator cannot handle unicodes like tabs (U+0009) and newlines (U+2028/9) for layout purposes and must be handled programmatically [1]. In addition, the default font PDType1Font.TIMES_ROMAN in the attribution-document-basic-bundle does not have certain Unicodes. Therefore a open source font should be added in the basic bundle.

Steps to reproduce

  • Use unicodes in antennaconfig.xml file when setting license text for a artifact.

Acceptance Criteria

  • A new open source font set is added in the attribution-document-basic-bundle.
  • The unicodes for tabs and newlines in license texts are replaced correctly.

Definition of Done

  • Acceptance criteria fulfilled
  • A test case is created to reproduce the bug
  • A PR is created, the CI infrastructure reports green, the bug test case proves that bug is fixed
  • The PR is reviewed and approved
  • No TODOs left in the code unless explained in the ticket, if something else is still open, this is summarized in a comment in the issue
  • Documentation is updated
@bs-ondem bs-ondem added the bug Something isn't working label Jun 30, 2020
bs-ondem added a commit to bosch-io/antenna that referenced this issue Jun 30, 2020
@bs-ondem
Replaces unavailable characters for the AttributionDocumentGenerator
a7b5d53 
The AttributionDocumentGenerator cannot handle unicodes like tabs
(U+0009) and newlines (U+2028, U+2029) for layour purposes. Therefore it
will be replaced manually. In addition, some unavailable unicodes are
also replaced.

Resolves eclipse-archived#548.

Signed-off-by: Onur Demirci <[email protected]>
@bs-ondem bs-ondem mentioned this issue Jun 30, 2020
Closed
1 task
@sschuberth sschuberth mentioned this issue Jul 6, 2020
Closed
@sschuberth
Copy link
Contributor

When adding an Open Source font to the basic template bundle, we should follow REUSE best practices to associate license information with the TTF files.

@sschuberth sschuberth mentioned this issue Oct 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attribution document bug with unicodes bosch-io/antenna
2 participants
@sschuberth @bs-ondem