Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edit button acts the same as regular left click (and locked mode thoughts) #5485

Open
Joelius300 opened this issue Jul 4, 2024 · 0 comments
Labels
External feedback This Issue is Based on Feedback from the Community

Comments

@Joelius300
Copy link
Contributor

Joelius300 commented Jul 4, 2024

In locked mode, clicking on an activity takes you to the detailed view of it but disallows dragging activities around and creating new ones (by dragging).
In unlocked mode, clicking on an activity opens the rough view of it (not sure what to call it, just the one with title, category, place, and schedule entries). In this mode, there is also a small edit button in the top right which appears on hover. I was only able to find it referenced in #678. I would expect this little button to take me to the detailed view so I can edit the contents of the activity, but instead it just opens the rough view like a regular left click does. I would personally love this, because then it won't disrupt the interaction flow and my muscle memory when switching between locked and unlocked mode anymore and reduce the number of clicks required to get to where I want fro 2 to 1 while preserving everything I can do currently. For me this is a very common action so I believe it would be worth it and the UI is already in place for it.

image

Tested on production eCamp3 with both Firefox and Chromium.

I even think there is an argument to be made to switch those two such that clicking on the activity always opens the detailed view regardless of the mode and the little edit button in the top right opens the rough one, as I would expect it's much less used because all the information is changed rarely (same options you have when creating), they can also be changed in the detailed view (except for adding schedule entries, only possible after #4500) and changing times is mostly done by dragging anyway (in my experience). As it's a dialog that needs to be confirmed when changing anything, I also don't see a benefit of it only being available in unlocked mode. Implementing this unification would reduce complexity quite a bit imo and the locked mode would just be a convenient safety feature to avoid accidentally dragging around activities without impairing the rest of the functionality. Arguably, accidentally creating a block would also not need to be protected because there is a modal dialog before anything happens which is immediately dismissible with Esc, "Cancel" or clicking anywhere outside. I really like the drag protection but from what I have experienced personally and heard from my team, it's more frustrating that the app has these two complex modes that prevent you from doing what you want in situations where you need confirmation anyway. It would of course be a breaking change but I personally think it might be worth it.
I would love to hear your thoughts on it!

@manuelmeister manuelmeister added the External feedback This Issue is Based on Feedback from the Community label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External feedback This Issue is Based on Feedback from the Community
Projects
None yet
Development

No branches or pull requests

2 participants