Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate frankenphp(caddy) from ingress for local development #5277

Open
usu opened this issue Jun 1, 2024 · 1 comment
Open

Seperate frankenphp(caddy) from ingress for local development #5277

usu opened this issue Jun 1, 2024 · 1 comment
Assignees

Comments

@usu
Copy link
Member

usu commented Jun 1, 2024

After merging #5123, I'd propose that we separate the path-forwarding functionality (ingress) from frankenphp.

Combining this has a few disadvantages:

The 2nd point comes from the fact that the processing order is different between dev and prod:

  • on prod: ingress --> varnish --> api
  • od dev: varnish --> caddy (as ingress) --> api

Adding a separate ingress on local dev would make the two more similar and hence less error prone.

As ingress we could use:

  • Caddy: similar config as we already have today
  • Nginx: if we want to stay as similar as possible to the deployment
@usu usu added the Meeting Discuss Am nächsten Core-Meeting besprechen label Jun 1, 2024
@manuelmeister
Copy link
Member

Core Meeting Decision

We vote for NGINX. We want the setup to be similar to the deployment.

@manuelmeister manuelmeister removed the Meeting Discuss Am nächsten Core-Meeting besprechen label Jun 4, 2024
@BacLuc BacLuc self-assigned this Jul 17, 2024
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jul 17, 2024
That we have a more similar setup in development as in prod.

Issue: ecamp#5277
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jul 17, 2024
That we have a more similar setup in development as in prod.

Issue: ecamp#5277
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jul 17, 2024
That we have a more similar setup in development as in prod.

Issue: ecamp#5277
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jul 17, 2024
That we have a more similar setup in development as in prod.

Issue: ecamp#5277
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jul 17, 2024
That we have a more similar setup in development as in prod.

Issue: ecamp#5277
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jul 17, 2024
That we have a more similar setup in development as in prod.

Issue: ecamp#5277
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jul 17, 2024
That we have a more similar setup in development as in prod.

Issue: ecamp#5277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants