Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading text when a search result has no title: This title is unavailable for guests, please login to see more information. #99

Open
sandbergja opened this issue Oct 21, 2020 · 3 comments

Comments

@sandbergja
Copy link
Contributor

I noticed there is already a TODO item in the code:

# TODO: make this configurable

Our patrons have found this very confusing, especially since it displays whether guest is true or false/the user is logged in or not!

Ideally, there wouldn't be items without titles in the first place. Failing that, it would be helpful to be able to configure this field, with a more sensible default value.

Also noting that the string isn't currently i18n-compatible.

@efrierson
Copy link
Collaborator

Do you have an example we could test. Agree, there should be no records without a title when in full-access mode, so I'd like to report the record to our content team. I did follow the search link in the issue report in your fork (a search for centos), but that no-title string doesn't appear in the first couple of pages of results.

Completely aside from the specific missing title problem, I have logged the request for configurability of this string. Thanks!

@sandbergja
Copy link
Contributor Author

If I remember correctly, I think I was accidentally setting guest=true, even when I thought it was false. So I don't think the records-without-titles issue is actually valid. Apologies for not updating this ticket accordingly!

@efrierson
Copy link
Collaborator

No prob - keeping it open to track the configurability of this string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants