Skip to content

Commit 2133173

Browse files
author
ebreen
committed
fix(distribution): add fail-fast cert type validation in export step
1 parent fa0b1cf commit 2133173

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,22 @@ jobs:
9797
SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }}
9898
KEYCHAIN_PASSWORD: ${{ secrets.KEYCHAIN_PASSWORD }}
9999
run: |
100-
# Make our keychain visible and default for exportArchive
101100
KEYCHAIN_PATH="$RUNNER_TEMP/app-signing.keychain-db"
102101
security default-keychain -s "$KEYCHAIN_PATH"
103102
security unlock-keychain -p "$KEYCHAIN_PASSWORD" "$KEYCHAIN_PATH"
104103
security list-keychain -d user -s "$KEYCHAIN_PATH" /Library/Keychains/System.keychain
105104
106-
# Debug: verify certificate is accessible
105+
# Verify the correct certificate type is present
106+
echo "Checking for Developer ID Application certificate..."
107+
if ! security find-identity -v -p codesigning "$KEYCHAIN_PATH" | grep -q "Developer ID Application"; then
108+
echo "::error::BUILD_CERTIFICATE_BASE64 does not contain a Developer ID Application certificate."
109+
echo "Found identities:"
110+
security find-identity -v -p codesigning "$KEYCHAIN_PATH"
111+
echo ""
112+
echo "Export your 'Developer ID Application' cert from Keychain Access as .p12,"
113+
echo "base64-encode it, and update the BUILD_CERTIFICATE_BASE64 secret."
114+
exit 1
115+
fi
107116
security find-identity -v -p codesigning "$KEYCHAIN_PATH"
108117
109118
EXPORT_PLIST="$RUNNER_TEMP/export-options.plist"

0 commit comments

Comments
 (0)