Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting tiny checks and R CMD check in two steps #45

Open
etiennebacher opened this issue Sep 18, 2023 · 2 comments
Open

Splitting tiny checks and R CMD check in two steps #45

etiennebacher opened this issue Sep 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@etiennebacher
Copy link
Member

etiennebacher commented Sep 18, 2023

All our CI jobs run at the same time but some are quite long (e.g R CMD check because of #37) while others should be quite quick (e.g styling, linting, and spellcheck).

The problem is that these quick checks might require tiny changes that don't influence the code at all, like fixing a typo or deleting a new line. When this happens, the new commits re-trigger the whole suite of tests, even R CMD check which shouldn't be affected by these tiny changes. Therefore, maybe there should be a "first run" of small CI jobs that check that everything's fine and when this passes, then we trigger the longer jobs like R CMD check.

I don't know the specific name of this but it looks like this in GHA (example from r-universe workflows):

image

I'm not sure how this would influence our dev workflow but it just annoys me to lose a few minutes every time there's a lint or some style to fix (and it also wastes some GHA minutes or just computing power). Would something like this make sense to you?

@IndrajeetPatil IndrajeetPatil added the enhancement New feature or request label Sep 18, 2023
@IndrajeetPatil
Copy link
Member

I think that's a good idea. Let me have a look into how this can be implemented.

@etiennebacher
Copy link
Member Author

etiennebacher commented Sep 19, 2023

Note that for those tiny checks, we could use ubuntu-latest with r2u to have a faster setup (currently lint-changed-files takes about 3 min to setup R and install the deps)

https://dirk.eddelbuettel.com/blog/2023/07/23/#041_simpler_ci_via_r2u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants